Shard python_torch_functions.cpp #62187
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit d443e36 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jul 26, 2021
Closed
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. [ghstack-poisoned]
albanD
reviewed
Jul 26, 2021
| pairs: Sequence[PythonSignatureNativeFunctionPair], | ||
| pred: Callable[[NativeFunction], bool] | ||
| ) -> Dict[BaseOperatorName, List[PythonSignatureNativeFunctionPair]]: | ||
| grouped: Dict[BaseOperatorName, List[PythonSignatureNativeFunctionPair]] = defaultdict(list) |
Collaborator
There was a problem hiding this comment.
Sometimes, I'm really not convinced that typing helps with readability...
|
|
||
| namespace torch { namespace autograd { | ||
|
|
||
| inline Tensor dispatch_arange(const Scalar& end, Tensor result) { |
Collaborator
There was a problem hiding this comment.
Do you know why we have so many of these bindings that are manual?
Collaborator
Author
There was a problem hiding this comment.
Not sure. I see that arange specifically was manually bound in #7016.
Collaborator
There was a problem hiding this comment.
cc @gchanan do you remember if this is still valid? :)
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. [ghstack-poisoned]
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. [ghstack-poisoned]
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. [ghstack-poisoned]
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. [ghstack-poisoned]
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Jul 26, 2021
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. ghstack-source-id: 4ffde84 Pull Request resolved: pytorch#62187
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Jul 26, 2021
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. ghstack-source-id: 4ffde84 Pull Request resolved: pytorch#62187
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. [ghstack-poisoned]
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. [ghstack-poisoned]
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. [ghstack-poisoned]
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. [ghstack-poisoned]
peterbell10
added
the
module: codegen
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. [ghstack-poisoned]
Collaborator
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. Differential Revision: [D29962048](https://our.internmc.facebook.com/intern/diff/D29962048) [ghstack-poisoned]
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. Differential Revision: [D29962048](https://our.internmc.facebook.com/intern/diff/D29962048) [ghstack-poisoned]
Collaborator
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This file can take 3 minutes on its own to compile, and after python_functions.cpp is the second limiting factor for compile time of `libtorch_python` on a 32-core threadripper. This splits it into 3 files that take around 1 minute each to compile. Differential Revision: [D29962048](https://our.internmc.facebook.com/intern/diff/D29962048) [ghstack-poisoned]
Collaborator
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This file can take 3 minutes on its own to compile, and after
python_functions.cpp is the second limiting factor for compile time of
libtorch_pythonon a 32-core threadripper. This splits it into 3 files thattake around 1 minute each to compile.
Differential Revision: D29962048