Skip to content

Fix sparse embedding backward when input contains only padding_idx #6211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soumith merged 1 commit into from
Apr 3, 2018
Merged

Fix sparse embedding backward when input contains only padding_idx #6211

soumith merged 1 commit into from
Apr 3, 2018

Conversation

@ssnl
Copy link
Collaborator

@ssnl ssnl commented Apr 2, 2018

Fixes #5472

ssnl
ssnl commented Apr 2, 2018
View reviewed changes
torch/nn/modules/sparse.py Outdated

This comment was marked as off-topic.

Sign in to view

@soumith soumith merged commit dfcd907 into pytorch:master Apr 3, 2018
@ssnl ssnl deleted the padidx branch April 3, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issue when using padding token as input to the network

3 participants

@ssnl @ezyang @soumith