Set dataloader.batch_size = None when batch_sampler is given #6108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaszke
reviewed
Mar 29, 2018
torch/utils/data/dataloader.py
Outdated
| :attr:`shuffle`, :attr:`sampler`, or :attr:`drop_last` is | ||
| invalid because such information is provided by | ||
| :attr:`batch_sampler`. In this case, the data loader will have | ||
| ``dataloader.batch_size == dataloader.drop_last == dataloader.sampler == None``. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Mar 29, 2018
apaszke
reviewed
Mar 29, 2018
Contributor
apaszke
left a comment
apaszke
left a comment
There was a problem hiding this comment.
LGTM, but let's remove the warning from the docs
torch/utils/data/dataloader.py
Outdated
| :attr:`shuffle`, :attr:`sampler`, or :attr:`drop_last` is | ||
| invalid because such information is provided by | ||
| :attr:`batch_sampler`. In this case, the data loader will have | ||
| ``dataloader.batch_size == dataloader.drop_last == dataloader.sampler == None``. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Collaborator
Author
|
@apaszke Removed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set dataloader's
batch_sizeanddrop_lasttoNonewhen `batch_sampler is given. Add a warning in doc for this case.Address #5884.