Skip to content

Add underscore to nn.init.* and deprecate the original ones #6093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ezyang merged 2 commits into from
Mar 29, 2018
Merged

Add underscore to nn.init.* and deprecate the original ones #6093

ezyang merged 2 commits into from
Mar 29, 2018

Conversation

@ssnl
Copy link
Collaborator

@ssnl ssnl commented Mar 29, 2018 •
edited
Loading

Fixes #5946.

@o8ht88z00f o8ht88z00f mentioned this pull request Mar 29, 2018
Closed
zou3519
zou3519 reviewed Mar 29, 2018
View reviewed changes
torch/nn/init.py
return meth(*args, **kwargs)

deprecated_init.__doc__ = r"""
{old_name}(...)

This comment was marked as off-topic.

Sign in to view

zou3519
zou3519 reviewed Mar 29, 2018
View reviewed changes
docs/source/nn.rst
.. autofunction:: uniform_
.. autofunction:: normal_
.. autofunction:: constant_
.. autofunction:: eye_

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@ezyang ezyang merged commit 4f05cb7 into pytorch:master Mar 29, 2018
@ssnl ssnl deleted the init_ branch March 29, 2018 17:26
@Ar-Kareem Ar-Kareem mentioned this pull request May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 left review comments

+1 more reviewer

@apaszke apaszke apaszke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feature request] Add underscore to nn.init functions

4 participants

@ssnl @apaszke @zou3519 @ezyang