Add noop register hook #60685
Closed
Add noop register hook #60685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jun 24, 2021
Contributor
💊 CI failures summary and remediationsAs of commit 8275c80 (more details on the Dr. CI page and at hud.pytorch.org/pr/60685):
Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Varal7
added a commit
to Varal7/pytorch
that referenced
this pull request
Jun 28, 2021
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ec6caab Pull Request resolved: pytorch#60685
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
soulitzer
approved these changes
Jun 29, 2021
Contributor
soulitzer
left a comment
soulitzer
left a comment
There was a problem hiding this comment.
Looks good, some small comments
albanD
reviewed
Jun 29, 2021
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
Author
|
@Varal7 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466224](https://our.internmc.facebook.com/intern/diff/D29466224) [ghstack-poisoned]
Contributor
Author
|
@Varal7 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466224](https://our.internmc.facebook.com/intern/diff/D29466224) [ghstack-poisoned]
Contributor
Author
|
@Varal7 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
This pull request has been merged in a5e2ea4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: This PR is part of a stack aimed to address #58512.
Expose a noop
register_hookmethod onSavedTensor. The purpose of this PR is to test error messages when the API is used incorrectly.Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D29466224