Register Saved Tensors hooks #60663
Closed
Register Saved Tensors hooks #60663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jun 24, 2021
Contributor
💊 CI failures summary and remediationsAs of commit c3fd243 (more details on the Dr. CI page and at hud.pytorch.org/pr/60663): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Varal7
added a commit
to Varal7/pytorch
that referenced
this pull request
Jun 28, 2021
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9554de6 Pull Request resolved: pytorch#60663
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
albanD
reviewed
Jun 29, 2021
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
Author
|
@Varal7 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466223](https://our.internmc.facebook.com/intern/diff/D29466223) [ghstack-poisoned]
**Summary**: This PR is part of a stack aimed to address #58512. Saves the hooks as a field of `SavedVariable` with type `std::unique_ptr<SavedVariableHooks>`. At this point, from the perspective of the user, `register_hooks` is still a no-op. The purpose of the PR is to create the class that will store the hooks. The logic of packing / unpacking will be added in the next PR. Differential Revision: [D29466223](https://our.internmc.facebook.com/intern/diff/D29466223) [ghstack-poisoned]
albanD
reviewed
Jul 14, 2021
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Looks good on my end.
I'll let @soulitzer get a final look
soulitzer
approved these changes
Jul 14, 2021
Contributor
soulitzer
left a comment
soulitzer
left a comment
There was a problem hiding this comment.
Looks good to me also!
Contributor
|
Also what's up with the TORCH_API/THP_CLASS macros, I noticed that you were tweaking that in the past couple iterations. What was the idea behind those changes? |
**Summary**: This PR is part of a stack aimed to address #58512. Saves the hooks as a field of `SavedVariable` with type `std::unique_ptr<SavedVariableHooks>`. At this point, from the perspective of the user, `register_hooks` is still a no-op. The purpose of the PR is to create the class that will store the hooks. The logic of packing / unpacking will be added in the next PR. Differential Revision: [D29466223](https://our.internmc.facebook.com/intern/diff/D29466223) [ghstack-poisoned]
Contributor
Author
|
@Varal7 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
Author
|
Thanks for the review @soulitzer and thank you @albanD for helping me debug this PR. So For posterity: if you have linking problems with symbols not found: If you want to debug windows builds and want to ssh |
**Summary**: This PR is part of a stack aimed to address #58512. Saves the hooks as a field of `SavedVariable` with type `std::unique_ptr<SavedVariableHooks>`. At this point, from the perspective of the user, `register_hooks` is still a no-op. The purpose of the PR is to create the class that will store the hooks. The logic of packing / unpacking will be added in the next PR. Differential Revision: [D29466223](https://our.internmc.facebook.com/intern/diff/D29466223) [ghstack-poisoned]
Varal7
added a commit
that referenced
this pull request
Jul 15, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Varal7
added a commit
that referenced
this pull request
Jul 15, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Contributor
Author
|
@Varal7 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Varal7
added a commit
that referenced
this pull request
Jul 15, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. The packing can be done with gradient tracking disabled as we will add back the correct grad_fn during unpacking. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Varal7
added a commit
that referenced
this pull request
Jul 15, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. The packing can be done with gradient tracking disabled as we will add back the correct grad_fn during unpacking. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Varal7
added a commit
that referenced
this pull request
Jul 15, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. The packing can be done with gradient tracking disabled as we will add back the correct grad_fn during unpacking. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Varal7
added a commit
that referenced
this pull request
Jul 15, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. The packing can be done with gradient tracking disabled as we will add back the correct grad_fn during unpacking. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Varal7
added a commit
that referenced
this pull request
Jul 15, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. The packing can be done with gradient tracking disabled as we will add back the correct grad_fn during unpacking. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Varal7
added a commit
that referenced
this pull request
Jul 15, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. The packing can be done with gradient tracking disabled as we will add back the correct grad_fn during unpacking. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Contributor
|
This pull request has been merged in ee5a97d. |
Varal7
added a commit
that referenced
this pull request
Jul 16, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. The packing can be done with gradient tracking disabled as we will add back the correct grad_fn during unpacking. Inplace operations done by the pack_hook on the original tensor (in the case `leaf || !output`) will be caught if the Saved tensor is used by another op. Inplace operations done by unpack_hook will unfortunately not be caught. We will add a warning in the docs that follows this PR. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Varal7
added a commit
that referenced
this pull request
Jul 16, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. The packing can be done with gradient tracking disabled as we will add back the correct grad_fn during unpacking. Inplace operations done by the pack_hook on the original tensor (in the case `leaf || !output`) will be caught if the Saved tensor is used by another op. Inplace operations done by unpack_hook will unfortunately not be caught. We will add a warning in the docs that follows this PR. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Varal7
added a commit
that referenced
this pull request
Jul 16, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. The packing can be done with gradient tracking disabled as we will add back the correct grad_fn during unpacking. Inplace operations done by the pack_hook on the original tensor (in the case `leaf || !output`) will be caught if the Saved tensor is used by another op. Inplace operations done by unpack_hook will unfortunately not be caught. We will add a warning in the docs that follows this PR. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Varal7
added a commit
that referenced
this pull request
Jul 16, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. The packing can be done with gradient tracking disabled as we will add back the correct grad_fn during unpacking. Inplace operations done by the pack_hook on the original tensor (in the case `leaf || !output`) will be caught if the Saved tensor is used by another op. Inplace operations done by unpack_hook will unfortunately not be caught. We will add a warning in the docs that follows this PR. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Varal7
added a commit
that referenced
this pull request
Jul 16, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. The packing can be done with gradient tracking disabled as we will add back the correct grad_fn during unpacking. Inplace operations done by the pack_hook on the original tensor (in the case `leaf || !output`) will be caught if the Saved tensor is used by another op. Inplace operations done by unpack_hook will unfortunately not be caught. We will add a warning in the docs that follows this PR. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Varal7
added a commit
that referenced
this pull request
Jul 16, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. The packing can be done with gradient tracking disabled as we will add back the correct grad_fn during unpacking. Inplace operations done by the pack_hook on the original tensor (in the case `leaf || !output`) will be caught if the Saved tensor is used by another op. Inplace operations done by unpack_hook will unfortunately not be caught. We will add a warning in the docs that follows this PR. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Varal7
added a commit
that referenced
this pull request
Jul 16, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. The packing can be done with gradient tracking disabled as we will add back the correct grad_fn during unpacking. Inplace operations done by the pack_hook on the original tensor (in the case `leaf || !output`) will be caught if the Saved tensor is used by another op. Inplace operations done by unpack_hook will unfortunately not be caught. We will add a warning in the docs that follows this PR. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Varal7
added a commit
that referenced
this pull request
Jul 16, 2021
Summary: Fixes #58512 Uses the hooks introduced in #60663: upon registering, the pack hook is called and the returned python object is stored. From then on, whenever we need to unpack it, we will use that python object in combination with the unpack hook. The packing can be done with gradient tracking disabled as we will add back the correct grad_fn during unpacking. Inplace operations done by the pack_hook on the original tensor (in the case `leaf || !output`) will be caught if the Saved tensor is used by another op. Inplace operations done by unpack_hook will unfortunately not be caught. We will add a warning in the docs that follows this PR. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29466227](https://our.internmc.facebook.com/intern/diff/D29466227) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This PR is part of a stack aimed to address #58512.
Saves the hooks as a field of
SavedVariablewith typestd::unique_ptr<SavedVariableHooks>.At this point, from the perspective of the user,
register_hooksis still a no-op.The purpose of the PR is to create the class that will store the hooks. The logic of packing / unpacking will be added in the next PR.
Differential Revision: D29466223