Skip to content

Block set from param_group['params'] #6031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soumith merged 4 commits into from
Mar 28, 2018
Merged

Block set from param_group['params'] #6031

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ae1792
Block set from param_group['params']
Jiaming-Liu Mar 27, 2018
fa59ebc
Update Error Message
Jiaming-Liu Mar 27, 2018
e3c2a5f
Add Warning on Optimizer Docs
Jiaming-Liu Mar 27, 2018
ac0a00f
Update optimizer.py
apaszke Mar 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions torch/optim/optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@
class Optimizer(object):
"""Base class for all optimizers.

.. warning::
Parameters needs to be specified as collections that have a deterministic
ordering that is consistent between runs. Examples of objects that don't
satisfy those properties are sets and iterators over values of dictionaries.

Arguments:
params (iterable): an iterable of :class:`Variable` s or
:class:`dict` s. Specifies what Variables should be optimized.
Expand Down Expand Up @@ -175,6 +180,9 @@ def add_param_group(self, param_group):
params = param_group['params']
if isinstance(params, Variable):
param_group['params'] = [params]
elif isinstance(params, set):
raise TypeError('optimizer parameters need to be organized in ordered collections, but '
'the ordering of tensors in sets will change between runs. Please use a list instead.')
else:
param_group['params'] = list(params)

Expand Down