Skip to content

fix bias size assert #5992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apaszke merged 5 commits into from
Mar 27, 2018
Merged

fix bias size assert #5992

apaszke merged 5 commits into from
Mar 27, 2018

Conversation

@elanmart
Copy link
Contributor

@elanmart elanmart commented Mar 25, 2018

Fixes #5990

@onnxbot-worker-3 onnxbot-worker-3 mentioned this pull request Mar 25, 2018
Closed
@elanmart
Copy link
Contributor Author

elanmart commented Mar 25, 2018

@pytorchbot retest this please

apaszke
apaszke reviewed Mar 25, 2018
View reviewed changes
aten/src/ATen/native/Linear.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@apaszke
Copy link
Contributor

apaszke commented Mar 25, 2018

Also, can you please add a test for Bilinear without bias? Just to make sure we won't have a regression again

ezyang
ezyang previously requested changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See @apaszke

@elanmart
Copy link
Contributor Author

elanmart commented Mar 26, 2018

@ezyang @apaszke Please excuse me the delay.

How should I read the onnx CI failure?

@soumith
Copy link
Contributor

soumith commented Mar 26, 2018

@elanmart the onnx failure means it's asking you to rebase :)

@elanmart
Copy link
Contributor Author

elanmart commented Mar 27, 2018

@pytorchbot retest this please.

@elanmart
Copy link
Contributor Author

elanmart commented Mar 27, 2018

The onnx failure seems unrelated [1], but I can't force the tests to run again :(

[1]

E: Failed to fetch http://dl.bintray.com/apache/cassandra/dists/39x/main/binary-amd64/Packages  502  Bad Gateway [IP: 52.27.175.225 80]

@apaszke
Copy link
Contributor

apaszke commented Mar 27, 2018

@onnxbot retest this please

apaszke
apaszke reviewed Mar 27, 2018
View reviewed changes
test/test_nn.py
_assertGradAndGradgradChecks(self, lambda x1, x2: F.bilinear(x1, x2, module.weight, module.bias),
(input1_1, input2_1))

def test_bilinear_no_bias(self):

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@ezyang ezyang dismissed their stale review March 27, 2018 14:51

new commit

@ezyang
Copy link
Contributor

ezyang commented Mar 27, 2018

@pytorchbot retest this please

apaszke
apaszke reviewed Mar 27, 2018
View reviewed changes
test/test_nn.py Outdated
output_no_bias = module_no_bias(input1, input2)

self.assertEqual(output, output_no_bias)
output_no_bias.sum().backward()

This comment was marked as off-topic.

Sign in to view

@apaszke apaszke merged commit 5583c12 into pytorch:master Mar 27, 2018
@elanmart elanmart deleted the bilinear-fix branch March 27, 2018 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang left review comments

+1 more reviewer

@apaszke apaszke apaszke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nn.Bilinear without bias broken

4 participants

@elanmart @apaszke @soumith @ezyang