-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Update ops.cpp #58807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ops.cpp #58807
Conversation
|
Hi @cksajil! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 9a6304b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #58807 +/- ##
==========================================
- Coverage 76.49% 76.49% -0.01%
==========================================
Files 2005 2005
Lines 200911 200911
==========================================
- Hits 153694 153683 -11
- Misses 47217 47228 +11 |
|
cc @suo do you know who would be best to review this? |
|
cc @hlu1 maybe? |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Fixes #{#5880}
#58804