Skip to content

Fix CUDA btrifact error message using wrong info type #5644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soumith merged 1 commit into from
Mar 9, 2018
Merged

Fix CUDA btrifact error message using wrong info type #5644

soumith merged 1 commit into from
Mar 9, 2018

Conversation

@ssnl
Copy link
Collaborator

@ssnl ssnl commented Mar 8, 2018 •
edited
Loading

btrifact's info is always an IntTensor. But when printing errors, we treat it as a real tensor, causing wrong error messages.

Before:

(Pdb) torch.btrifact(torch.zeros(1,3,3).cuda())
*** RuntimeError: failed to factorize some batch elements (min info == 1435440384, max info
 == 19942608) at /home/ssnl/sftp/pytorch/aten/src/THC/generic/THCTensorMathBlas.cu:811
(Pdb) torch.btrifact(torch.zeros(1,3,3))
*** RuntimeError: failed to factorize batch element 0 (info == 1) at /home/ssnl/sftp/pytorc
h/aten/src/TH/generic/THTensorLapack.c:1020

After:

(Pdb) torch.btrifact(torch.zeros(1,3,3).cuda())
*** RuntimeError: failed to factorize some batch elements (min info == 1, max info == 1) at
 /home/ssnl/sftp/pytorch/aten/src/THC/generic/THCTensorMathBlas.cu:811
(Pdb) torch.btrifact(torch.zeros(1,3,3))
*** RuntimeError: failed to factorize batch element 0 (info == 1) at /home/ssnl/sftp/pytorc
h/aten/src/TH/generic/THTensorLapack.c:1020

@onnxbot-worker-1 onnxbot-worker-1 mentioned this pull request Mar 8, 2018
Closed
zou3519
zou3519 approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@soumith soumith merged commit 8f068bd into pytorch:master Mar 9, 2018
@ssnl ssnl deleted the cuda_btrifact_info_err_msg branch March 9, 2018 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ssnl @zou3519 @ezyang @soumith