Give std/var correction overloads proper defaults #56398
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
Contributor
🔗 Helpful links
❌ 7 New FailuresAs of commit 44f3fa8 (more details on the Dr. CI page): Expand to see more
🕵️ 7 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
This was referenced Apr 19, 2021
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Apr 29, 2021
ghstack-source-id: 430384f Pull Request resolved: pytorch#56398
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
May 4, 2021
ghstack-source-id: 430384f Pull Request resolved: pytorch#56398
[ghstack-poisoned]
[ghstack-poisoned]
Collaborator
Author
|
@mruberry PTAL, forward-compat period should be over now. |
Collaborator
Author
|
@malfet @seemethere ping |
Contributor
|
Let me reimport it to check it will not regress mobile builds, that sometimes rigidly depend on operator signatures |
Contributor
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
The correction overloads defaults were left off for forward compatibility reasons, but this FC window expired well over a year ago at this point. Differential Revision: [D29625593](https://our.internmc.facebook.com/intern/diff/D29625593) cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx jansel lezcano fdrocha [ghstack-poisoned]
The correction overloads defaults were left off for forward compatibility reasons, but this FC window expired well over a year ago at this point. Differential Revision: [D29625593](https://our.internmc.facebook.com/intern/diff/D29625593) cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx jansel lezcano fdrocha [ghstack-poisoned]
The correction overloads defaults were left off for forward compatibility reasons, but this FC window expired well over a year ago at this point. Differential Revision: [D29625593](https://our.internmc.facebook.com/intern/diff/D29625593) cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx jansel lezcano fdrocha [ghstack-poisoned]
The correction overloads defaults were left off for forward compatibility reasons, but this FC window expired well over a year ago at this point. Differential Revision: [D29625593](https://our.internmc.facebook.com/intern/diff/D29625593) cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx jansel lezcano fdrocha [ghstack-poisoned]
Collaborator
Author
|
@malfet were there any mobile issues? |
Collaborator
|
@malfet what's the state of this PR? Can we land it? |
Contributor
|
@pytorchbot rebase |
Collaborator
|
@pytorchbot successfully started a rebase job. Check the current status here |
Collaborator
|
Rebase failed due to Command Raised by https://github.com/pytorch/pytorch/actions/runs/3605373520 |
Contributor
|
Sorry for the late reply, but can you please rebase again the latest PyTorch and I'll try to import it again (as you can see it can not be imported as is, as it conflicts with the latest trunk, see above rebase failures) |
The correction overloads defaults were left off for forward compatibility reasons, but this FC window expired well over a year ago at this point. Differential Revision: [D29625593](https://our.internmc.facebook.com/intern/diff/D29625593) cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx jansel lezcano fdrocha [ghstack-poisoned]
Contributor
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
Contributor
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
Ok, just landed internally, I wonder if it will be auto-closed by the bot now... |
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Dec 7, 2022
The correction overloads defaults were left off for forward compatibility reasons, but this FC window expired well over a year ago at this point. ghstack-source-id: 2215cb3 Pull Request resolved: pytorch#56398
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
The correction overloads defaults were left off for forward compatibility reasons, but this FC window expired well over a year ago at this point. Differential Revision: [D29625593](https://our.internmc.facebook.com/intern/diff/D29625593) Pull Request resolved: pytorch#56398 Approved by: https://github.com/mruberry
ngimel
reviewed
Jan 7, 2023
| yield SampleInput(tensor_nd(), correction=0, keepdim=True) | ||
|
|
||
|
|
||
| def sample_inputs_std_var_unbiased(op_info, device, dtype, requires_grad, **kwargs): |
Collaborator
There was a problem hiding this comment.
why do we need unbiased variants of OpInfos? Can't we add them to the regular sample inputs function?
Collaborator
Author
There was a problem hiding this comment.
The unbiased variant has supports_out=False due to some overloads not having an equivalent out overload, while correction overloads supports the out argument on all signatures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
correctionvalue andunbiasedargument #55679The correction overloads defaults were left off for forward
compatibility reasons, but this FC window expired well over a year ago
at this point.
Differential Revision: D29625593
cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire @jansel @lezcano @fdrocha