Alias torch.diagonal, torch.diagflat #5622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesbury
reviewed
Mar 9, 2018
aten/src/ATen/native/TensorShape.cpp
Outdated
| } | ||
|
|
||
| Tensor diagflat(const Tensor& self, int64_t offset) { | ||
| return self.view(-1).diag(offset); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
colesbury
reviewed
Mar 9, 2018
torch/_torch_docs.py
Outdated
| -1.0817 | ||
| [torch.FloatTensor of size 3] | ||
| >>> torch.diag(a, 1) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
|
I think this is a good idea. It's worth adding the sanity checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3213
This adds
torch.diagonalandtorch.diagflat(like in numpy) to solve the problem thattorch.diagis unintuitive to users and performs two functions. The implementations oftorch.diagonalandtorch.diagflatjust calltorch.diag.I'm not sure if this is the best idea to solve the problem of
torch.diagbeing weird to users because this does complicate the API (with this change, there will be 3 diag functions). If we think this is a good idea, I'll add some quick sanity tests to test_torch and test_cuda to check thattorch.diagonalandtorch.diagflatdo what they're supposed to.cc @gchanan @colesbury