std/var: Require correction parameter always be given explicitly #55680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Apr 9, 2021
Contributor
🔗 Helpful links
❌ 26 New FailuresAs of commit 777839e (more details on the Dr. CI page): Expand to see more
🕵️ 26 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
May 4, 2021
ghstack-source-id: 9b51349 Pull Request resolved: pytorch#55680
[ghstack-poisoned]
…icitly" This changes the default `None` correction and all overloads using the unbiased parameter result in an error. BC-breaking message: `torch.std`, `torch.std_mean`, `torch.var` and `torch.var_mean` now require the `correction` argument be passed in all function calls. This means it cannot be left as defaulted and also the `unbiased` overloads cannot be used any more. To recover the old default, use `correction=1` which is equivalent to `unbiased=True`; or use `correction=0` for the same behavior as `unbiased=False`. [ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Nov 2, 2022
This changes the default `None` correction and all overloads using the unbiased parameter result in an error. BC-breaking message: `torch.std`, `torch.std_mean`, `torch.var` and `torch.var_mean` now require the `correction` argument be passed in all function calls. This means it cannot be left as defaulted and also the `unbiased` overloads cannot be used any more. To recover the old default, use `correction=1` which is equivalent to `unbiased=True`; or use `correction=0` for the same behavior as `unbiased=False`. ghstack-source-id: e566ff4 Pull Request resolved: #55680
…icitly" This changes the default `None` correction and all overloads using the unbiased parameter result in an error. BC-breaking message: `torch.std`, `torch.std_mean`, `torch.var` and `torch.var_mean` now require the `correction` argument be passed in all function calls. This means it cannot be left as defaulted and also the `unbiased` overloads cannot be used any more. To recover the old default, use `correction=1` which is equivalent to `unbiased=True`; or use `correction=0` for the same behavior as `unbiased=False`. [ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Nov 3, 2022
This changes the default `None` correction and all overloads using the unbiased parameter result in an error. BC-breaking message: `torch.std`, `torch.std_mean`, `torch.var` and `torch.var_mean` now require the `correction` argument be passed in all function calls. This means it cannot be left as defaulted and also the `unbiased` overloads cannot be used any more. To recover the old default, use `correction=1` which is equivalent to `unbiased=True`; or use `correction=0` for the same behavior as `unbiased=False`. ghstack-source-id: e566ff4 Pull Request resolved: #55680
…icitly" This changes the default `None` correction and all overloads using the unbiased parameter result in an error. BC-breaking message: `torch.std`, `torch.std_mean`, `torch.var` and `torch.var_mean` now require the `correction` argument be passed in all function calls. This means it cannot be left as defaulted and also the `unbiased` overloads cannot be used any more. To recover the old default, use `correction=1` which is equivalent to `unbiased=True`; or use `correction=0` for the same behavior as `unbiased=False`. [ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Nov 7, 2022
This changes the default `None` correction and all overloads using the unbiased parameter result in an error. BC-breaking message: `torch.std`, `torch.std_mean`, `torch.var` and `torch.var_mean` now require the `correction` argument be passed in all function calls. This means it cannot be left as defaulted and also the `unbiased` overloads cannot be used any more. To recover the old default, use `correction=1` which is equivalent to `unbiased=True`; or use `correction=0` for the same behavior as `unbiased=False`. ghstack-source-id: 3f68338 Pull Request resolved: #55680
…icitly" This changes the default `None` correction and all overloads using the unbiased parameter result in an error. BC-breaking message: `torch.std`, `torch.std_mean`, `torch.var` and `torch.var_mean` now require the `correction` argument be passed in all function calls. This means it cannot be left as defaulted and also the `unbiased` overloads cannot be used any more. To recover the old default, use `correction=1` which is equivalent to `unbiased=True`; or use `correction=0` for the same behavior as `unbiased=False`. [ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Dec 4, 2022
This changes the default `None` correction and all overloads using the unbiased parameter result in an error. BC-breaking message: `torch.std`, `torch.std_mean`, `torch.var` and `torch.var_mean` now require the `correction` argument be passed in all function calls. This means it cannot be left as defaulted and also the `unbiased` overloads cannot be used any more. To recover the old default, use `correction=1` which is equivalent to `unbiased=True`; or use `correction=0` for the same behavior as `unbiased=False`. ghstack-source-id: 2de2a7a Pull Request resolved: #55680
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Dec 7, 2022
This changes the default `None` correction and all overloads using the unbiased parameter result in an error. BC-breaking message: `torch.std`, `torch.std_mean`, `torch.var` and `torch.var_mean` now require the `correction` argument be passed in all function calls. This means it cannot be left as defaulted and also the `unbiased` overloads cannot be used any more. To recover the old default, use `correction=1` which is equivalent to `unbiased=True`; or use `correction=0` for the same behavior as `unbiased=False`. ghstack-source-id: 2de2a7a Pull Request resolved: pytorch#55680
…icitly" This changes the default `None` correction and all overloads using the unbiased parameter result in an error. BC-breaking message: `torch.std`, `torch.std_mean`, `torch.var` and `torch.var_mean` now require the `correction` argument be passed in all function calls. This means it cannot be left as defaulted and also the `unbiased` overloads cannot be used any more. To recover the old default, use `correction=1` which is equivalent to `unbiased=True`; or use `correction=0` for the same behavior as `unbiased=False`. [ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Dec 7, 2022
This changes the default `None` correction and all overloads using the unbiased parameter result in an error. BC-breaking message: `torch.std`, `torch.std_mean`, `torch.var` and `torch.var_mean` now require the `correction` argument be passed in all function calls. This means it cannot be left as defaulted and also the `unbiased` overloads cannot be used any more. To recover the old default, use `correction=1` which is equivalent to `unbiased=True`; or use `correction=0` for the same behavior as `unbiased=False`. ghstack-source-id: d2710e1 Pull Request resolved: #55680
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Contributor
|
No one has reviewed this, and the original author has removed stale and added no-stale, even though there has been no activity in more than a year. |
|
@pytorchbot rebase |
Collaborator
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Collaborator
|
Rebase failed due to Command Raised by https://github.com/pytorch/pytorch/actions/runs/8254193916 |
Collaborator
Author
|
Closing as the deprecation isn't going ahead, see #50010 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
correctionvalue andunbiasedargument #55679This changes the default
Nonecorrection and all overloads using theunbiased parameter result in an error.
BC-breaking message:
torch.std,torch.std_mean,torch.varandtorch.var_meannowrequire the
correctionargument be passed in all function calls.This means it cannot be left as defaulted and also the
unbiasedoverloads cannot be used any more. To recover the old default, use
correction=1which is equivalent tounbiased=True; or usecorrection=0for the same behavior asunbiased=False.