Handle copying empty sparse tensors to/from CPU, GPU. #5361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is likely not a robust fix because it special cases the case where both the indices and values are empty rather than handling each one separately. But this is currently blocking a change introducing devices to constructors.
zou3519
reviewed
Feb 23, 2018
Contributor
zou3519
left a comment
zou3519
left a comment
There was a problem hiding this comment.
Looks good! I had one minor comment
| // TODO: we may need to special case when only one of these are empty. | ||
| if (THLongTensor_nDimension(indices) == 0 && THTensor_(nDimension)(values) == 0) { | ||
| nDimI = 0; | ||
| nDimV = THLongStorage_size(sizes); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| // TODO: we may need to special case when only one of these are empty. | ||
| if (THCudaLongTensor_nDimension(state, indices) == 0 && THCTensor_(nDimension)(state, values) == 0) { | ||
| nDimI = 0; | ||
| nDimV = THLongStorage_size(sizes); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
onnx failures are unrelated |
jamesr66a
pushed a commit
to jamesr66a/pytorch
that referenced
this pull request
Feb 24, 2018
* Handle copying empty sparse tensors to/from CPU, GPU. This is likely not a robust fix because it special cases the case where both the indices and values are empty rather than handling each one separately. But this is currently blocking a change introducing devices to constructors. * Guard sizes being NULL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely not a robust fix because it special cases the case where both the indices and values are empty rather than handling each one separately. But this is currently blocking a change introducing devices to constructors.