Use ArrayRef<Scalar> for List of Scalar in codegen #53581
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We will pass `Scalar` by reference in the following commit. For a list of Scalar, `ScalarList` will be used as the type, otherwise `ArrayRef<const Scalar&>` will be generated as the type by default. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit ade75c3 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 9, 2021
added 2 commits
March 8, 2021 22:40
Summary: We will pass `Scalar` by reference in the following commit. For a list of Scalar, `ScalarList` will be used as the type, otherwise `ArrayRef<const Scalar&>` will be generated as the type by default. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D26904443](https://our.internmc.facebook.com/intern/diff/D26904443) [ghstack-poisoned]
Summary: We will pass `Scalar` by reference in the following commit. For a list of Scalar, `ScalarList` will be used as the type, otherwise `ArrayRef<const Scalar&>` will be generated as the type by default. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D26904443](https://our.internmc.facebook.com/intern/diff/D26904443) [ghstack-poisoned]
Contributor
|
as discussed offline, let's just use |
Summary: We will pass `Scalar` by reference in the following commit. For a list of Scalar, `ScalarList` will be used as the type, otherwise `ArrayRef<const Scalar&>` will be generated as the type by default. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D26904443](https://our.internmc.facebook.com/intern/diff/D26904443) [ghstack-poisoned]
wenleix
changed the title
Contributor
Author
|
Squashed into #53583 as it's now just one line change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
We will pass
Scalarby reference in the following commit.For a list of Scalar,
ScalarListwill be used as the type,otherwise
ArrayRef<const Scalar&>will be generated as the typeby default.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D26904443