Change call Scalar by reference #53467
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 4a205aa (more details on the Dr. CI page):
🕵️ 24 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 binary_linux_libtorch_3_7m_cpu_devtoolset7_shared-with-deps_build |
Build | 🔁 rerun |
| pytorch_ios_12_0_0_x86_64_build |
Build | 🔁 rerun |
| pytorch_ios_12_0_0_x86_64_lite_interpreter_build |
Build | 🔁 rerun |
ci.pytorch.org: 2 failed
- Failed:
pr/caffe2-pytorch-linux-bionic-rocm4.0.1-py3.6-test - Failed:
pr/pytorch-linux-bionic-rocm4.0.1-py3.6
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
This was referenced Mar 7, 2021
Closed
Contributor
Author
|
This PR/commit is based on #52825, with some removals. |
wenleix
commented
Mar 8, 2021
tools/codegen/api/translate.py
Outdated
| options = direct_solve(options_ctype) | ||
| return f'{options}.pinned_memory_opt()' | ||
|
|
||
| elif isinstance(goal, OptionalCType) and goal.elem.type == "Scalar": |
Contributor
Author
There was a problem hiding this comment.
Looks like mypy complaints about type inference here: https://app.circleci.com/pipelines/github/pytorch/pytorch/282083/workflows/93049392-4333-49e7-bdac-3fad6954c5a0/jobs/11365785
Traceback (most recent call last):
File "test_type_hints.py", line 173, in test_run_mypy
self.fail(f"mypy failed: {stdout} {stderr}")
AssertionError: mypy failed: tools/codegen/api/translate.py:184:50: error: Item "OptionalCType" of "Union[BaseCType, OptionalCType, ConstRefCType, MutRefCType]" has no attribute "type"
tools/codegen/api/translate.py:184:50: error: Item "ConstRefCType" of "Union[BaseCType, OptionalCType, ConstRefCType, MutRefCType]" has no attribute "type"
tools/codegen/api/translate.py:184:50: error: Item "MutRefCType" of "Union[BaseCType, OptionalCType, ConstRefCType, MutRefCType]" has no attribute "type"
tools/codegen/api/translate.py:185:20: error: Incompatible return value type (got "Union[str, SpecialArgName]", expected "str")
tools/codegen/api/translate.py:187:14: error: Item "OptionalCType" of "Union[BaseCType, OptionalCType, ConstRefCType, MutRefCType]" has no attribute "type"
tools/codegen/api/translate.py:187:14: error: Item "ConstRefCType" of "Union[BaseCType, OptionalCType, ConstRefCType, MutRefCType]" has no attribute "type"
tools/codegen/api/translate.py:187:14: error: Item "MutRefCType" of "Union[BaseCType, OptionalCType, ConstRefCType, MutRefCType]" has no attribute "type"
tools/codegen/api/translate.py:188:20: error: Incompatible return value type (got "Union[str, SpecialArgName]", expected "str")
Found 8 errors in 1 file (checked 20 source files)
cc @smessmer
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D26873799](https://our.internmc.facebook.com/intern/diff/D26873799) [ghstack-poisoned]
Contributor
Author
|
Reorganize the stack so there are only two PRs in the stack (see #53583) . Close PRs no longer exist in stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Based on #52825, with some removals.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D26873799