Skip to content

Make ReduceLROnPlateau serializable. #5300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soumith merged 2 commits into from
Feb 20, 2018
Merged

Make ReduceLROnPlateau serializable. #5300

soumith merged 2 commits into from
Feb 20, 2018

Conversation

@elanmart
Copy link
Contributor

@elanmart elanmart commented Feb 19, 2018

This PR replaces lambdas with partial, therefore making the ReduceLROnPlateau class serializable without dill.

Resolves #5218

@onnxbot-worker-1 onnxbot-worker-1 mentioned this pull request Feb 19, 2018
Closed
ezyang
ezyang approved these changes Feb 20, 2018
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@soumith soumith merged commit d2ff733 into pytorch:master Feb 20, 2018
@soumith
Copy link
Contributor

soumith commented Feb 20, 2018

thanks Marcin!

@kahne kahne mentioned this pull request May 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Saving ReduceLROnPlateau crashes

3 participants

@elanmart @soumith @ezyang