Speed-up nn.Linear for the 3d input case #5279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds at::_unsafe_view and uses it in matmul. The _unsafe_view function is identical to view except that the output is not treated like a view by the automatic differentiation code. This avoids in-place modifications triggering the more expensive CopySlices/AsStridedBackward behavior. The _unsafe_view function is only safe to use on temporaries that will be immediately discarded and that do not alias other tensors. Otherwise, in-place modificatiions may trigger incorrect gradients. The funciton is not exposed to Python. See pytorch#5169
gchanan
approved these changes
Feb 17, 2018
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
lgtm. What do you think about adding something to the function name describing why it's unsafe? unsafe_view_tmp_nonalias or something? I'm sure you can come up with a better name.
Contributor
|
@pytorchbot retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds at::_unsafe_view and uses it in matmul. The _unsafe_view
function is identical to view except that the output is not treated
like a view by the automatic differentiation code. This avoids in-place
modifications triggering the more expensive CopySlices/AsStridedBackward
behavior.
The _unsafe_view function is only safe to use on temporaries that will
be immediately discarded and that do not alias other tensors. Otherwise,
in-place modificatiions may trigger incorrect gradients. The funciton is
not exposed to Python.
See #5169
cc @ngimel @csarofeen