Implement torch.isnan #5273
Merged
Implement torch.isnan #5273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR, but can't this be implemented like this (for floating point tensor types): def isnan(x):
return x != x |
Contributor
Author
|
Of course, we can implement like that. uploaded a new patch. |
soumith
approved these changes
Feb 16, 2018
apaszke
approved these changes
Feb 16, 2018
Contributor
|
@pytorchbot test this please |
Contributor
|
thanks @tunz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please take a look.
I implemented
torch.isnanin C/C++. You can use this function as following:Since it's my first contribution to your project, I'm not familiar with testing or coding style, so please let me know if something's wrong.
Ref: #4767