Added check and test for betas parameter in Adam optimizer #5147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaszke
suggested changes
Feb 9, 2018
test/test_optim.py
Outdated
| torch.randn(10), | ||
| torch.randn(5), | ||
| constructor | ||
| ) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
test/test_optim.py
Outdated
| lambda weight, bias: optim.Adam( | ||
| [weight, bias], lr=1e-2, betas=(1.0, 0.0), amsgrad=True), | ||
| "Invalid beta parameter at index 0: 1.0" | ||
| ) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
@apaszke I have reduced the test. Please review |
apaszke
approved these changes
Feb 11, 2018
Contributor
|
@pytorchbot test this please |
Contributor
|
thank you @lazypanda1 ! |
This was referenced Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to prevent division by zero errors and give users friendlier error messages when using the Adam optimizer.
Currently, if one specifies the beta value of the Adam optimizer as
1.0for the first parameter, the program fails with the error message,ZeroDivisionError: float division by zero. According to the definition of Adam, beta values should be in the range [0, 1).Also referring #751 where I encountered and tried to fix this issue in the first place. I believe this would benefit all clients using pytorch as backend.