Fix maxpool3d / avgpool3d crashs #5052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zou3519
changed the title
Contributor
|
you're doing a double-free of a THCTensor somewhere. See contbuild. |
ssnl
reviewed
Feb 5, 2018
Collaborator
ssnl
left a comment
ssnl
left a comment
There was a problem hiding this comment.
Thanks! Looks great. Could you also remove the now obsolete downcastOuter and downcastInner?
aten/src/THC/generic/THCTensor.c
Outdated
| return self; | ||
| } | ||
|
|
||
| // Collapses the first two dimensions of a tensor |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
@ssnl I looked at the code for |
ssnl
approved these changes
Feb 5, 2018
Collaborator
ssnl
left a comment
ssnl
left a comment
There was a problem hiding this comment.
LGTM. Merge-able when CI passes.
soumith
pushed a commit
that referenced
this pull request
Feb 7, 2018
* Replace downcastOuter with newFoldBatchDim * Fix double free * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4835. This PR picks up from #4848
There's a bug in
THCDeviceTensor::downcastOuterwhere it sometimes doesn't recognize a contiguous tensor as being contiguous. This leads to crashes inmaxpool3d,avgpool3d.This PR removes usages of
THCDeviceTensor::downcastOuterand replaces it with a call tonewFoldBatchDim, which performs the same behavior of collapsing the batch and feature dims but usesnewViewinternally.cc @ssnl
Test Plan
New unit tests for maxpool3d and avgpool3d crashes. Run
test_nnto make sure maxpool3d, avgpool3d, and maxunpool3d still work.