Skip to content

Fix blas addmm (gemm) condition check #5048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soumith merged 1 commit into from
Feb 5, 2018
Merged

Fix blas addmm (gemm) condition check #5048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions aten/src/TH/generic/THTensorMath.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2004,15 +2004,15 @@ void THTensor_(addmm)(THTensor *r_, real beta, THTensor *t, real alpha, THTensor
int64_t ldr__ = r__->stride[(transpose_r == 'n' ? 1 : 0)];

/* m1 */
/* Need ldm1_ >= max(1, (transpose_m1 == 't' ? m : k)) */
/* Need ldm1_ >= max(1, (transpose_m1 == 'n' ? m : k)) */
if(m1->stride[(transpose_r == 'n' ? 0 : 1)] == 1 &&
m1->stride[(transpose_r == 'n' ? 1 : 0)] >= THMax(1, k))
m1->stride[(transpose_r == 'n' ? 1 : 0)] >= THMax(1, m))
{
transpose_m1 = 'n';
m1_ = m1;
}
else if(m1->stride[(transpose_r == 'n' ? 1 : 0)] == 1 &&
m1->stride[(transpose_r == 'n' ? 0 : 1)] >= THMax(1, m))
m1->stride[(transpose_r == 'n' ? 0 : 1)] >= THMax(1, k))
{
transpose_m1 = 't';
m1_ = m1;
Expand All @@ -2025,7 +2025,7 @@ void THTensor_(addmm)(THTensor *r_, real beta, THTensor *t, real alpha, THTensor
}

/* m2 */
/* Need ldm2_ >= max(1, (transpose_m2 == 't' ? n : k)) */
/* Need ldm2_ >= max(1, (transpose_m2 == 'n' ? k : n)) */
if(m2->stride[(transpose_r == 'n' ? 0 : 1)] == 1 &&
m2->stride[(transpose_r == 'n' ? 1 : 0)] >= THMax(1, k))
{
Expand Down