Assemble technical overview of FX #50291
Conversation
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit ec42c7a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
jamesr66a
left a comment
jamesr66a
left a comment
There was a problem hiding this comment.
Cool! It's going to be great to have this information publicly-accessible
[ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/ansleyadelaide/29/base #50291 +/- ##
==========================================================
Coverage 80.69% 80.69%
==========================================================
Files 1902 1902
Lines 206335 206335
==========================================================
+ Hits 166494 166497 +3
+ Misses 39841 39838 -3 |
jamesr66a
left a comment
jamesr66a
left a comment
There was a problem hiding this comment.
Cool! There's some stuff duplicated form the fx/__init__.py docstring, like the description of the IR nodes. IMO we should deduplicate things and refer to that docstring as the single place this is described. This doc should be more focused on "below the cut" implementation details that are not in the public docstrings
[ghstack-poisoned]
Differential Revision: [D25908444](https://our.internmc.facebook.com/intern/diff/D25908444) [ghstack-poisoned]
Stack from ghstack:
Differential Revision: D25908444