Add Linux Jenkins scripts to PyTorch repo. #4910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting these scripts here has a few benefits: 1. PyTorch developers can easily update the scripts without having to ask for permissions to ossci-job-dsl 2. You can test changes in the scripts by opening a PR to PyTorch (functionality is ossci-job-dsl is not easily testable.) 3. If you get one of our stock Docker images, you can run these scripts to trigger a build identical to what would occur in Jenkins (not entirely true yet, but we can make it so.) Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
Author
|
@pytorchbot retest this please |
1 similar comment
Contributor
Author
|
@pytorchbot retest this please |
Contributor
|
Why not keep them in |
Contributor
|
then we cant open a PR and test script changes |
yf225
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting these scripts here has a few benefits:
PyTorch developers can easily update the scripts without
having to ask for permissions to ossci-job-dsl
You can test changes in the scripts by opening a PR to
PyTorch (functionality is ossci-job-dsl is not easily testable.)
If you get one of our stock Docker images, you can run these scripts
to trigger a build identical to what would occur in Jenkins (not
entirely true yet, but we can make it so.)
Signed-off-by: Edward Z. Yang ezyang@fb.com