Deprecate out-of-place resize and resize_as on Variables. #4886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
These don't work on scalars, but probably not worth the effort to make them work. |
colesbury
reviewed
Jan 27, 2018
torch/autograd/variable.py
Outdated
| return super(Variable, self).btrifact(pivot=pivot) | ||
|
|
||
| def resize(self, *sizes): | ||
| warnings.warn("non-inplace resize is deprecated", DeprecationWarning) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
colesbury
approved these changes
Jan 29, 2018
Member
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
The macos build failure doesn't look good, but I don't think it's related
Contributor
Author
|
MacOS and windows failures look unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.