Don't throw exceptions inside OpenMP parallel blocks #4857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @yf225 |
Fixes undefined behavior: exceptions are not allowed to be thrown across OpenMP constructs.
colesbury
force-pushed
the
take_put_omp
branch
from
5817921 to
bebed9f
Compare
Contributor
|
@pytorchbot retest this please |
Contributor
|
CPU perf test fail seems to be intermittent. Retesting works: https://ci.pytorch.org/jenkins/job/pytorch-builds/job/short-perf-test-cpu/305/console. |
gchanan
approved these changes
Jan 25, 2018
| dst_data[i] = src_data[THTensor_(dataOffset)(src, idx)]; | ||
| } | ||
| } else { | ||
| THAtomicCompareAndSwapLong(&invalidIdx, -1, idx); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
soumith
pushed a commit
that referenced
this pull request
Feb 7, 2018
Fixes undefined behavior: exceptions are not allowed to be thrown across OpenMP constructs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes undefined behavior: exceptions are not allowed to be thrown across
OpenMP constructs.