Implement CUDA-based gamma sampling #4839
Conversation
|
@rachtsingh, thanks for your PR! We identified @zdevito to be a potential reviewer. |
|
@rachtsingh I think you have accidentally updated the subtrees |
|
Yes, sorry, just fixed (I think my understanding of subtrees is still a little incomplete). |
|
Ok, I think it's ready for review - don't love the code dedup solution but very open to alternatives. Maybe @apaszke ? |
| @unittest.skipIf(not TEST_NUMPY, "Numpy not found") | ||
| def test_poisson_gpu_sample(self): | ||
| set_rng_seed(0) | ||
| set_rng_seed(1) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
can you manually check that |
|
Sure, running the build now. |
|
Ok, it works just fine after I cleaned and rebuilt with |
|
this is no longer ready for review, assuming the changes in this PR: #4892 affect it. I'll revisit this later today and see what changes need to be made. |
|
Closing for now to avoid retriggering spurious builds (and because it doesn't work as-is) |
5 participants
I've taken a stab at reducing code duplication between the CUDA/CPU implementations using one strategy, but happy to try something else if there's an alternative.