Skip to content

Fix embedding with sparse=True #4686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
colesbury merged 2 commits into from
Jan 16, 2018
Merged

Fix embedding with sparse=True #4686

colesbury merged 2 commits into from
Jan 16, 2018

Conversation

@colesbury
Copy link
Member

@colesbury colesbury commented Jan 16, 2018

Fixes #4666

@colesbury colesbury requested a review from gchanan January 16, 2018 18:54
@pytorchbot
Copy link
Collaborator

pytorchbot commented Jan 16, 2018

@colesbury, thanks for your PR! We identified @zdevito to be a potential reviewer.

gchanan
gchanan approved these changes Jan 16, 2018
View reviewed changes
Copy link
Contributor

@gchanan gchanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@colesbury
Copy link
Member Author

colesbury commented Jan 16, 2018

@ngimel yes! Thanks for the reminder. I'll add it in a subsequent PR

@colesbury colesbury merged commit cb83474 into pytorch:master Jan 16, 2018
@colesbury colesbury deleted the embed_sparse branch January 16, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gchanan gchanan gchanan approved these changes

+1 more reviewer

@soumith soumith soumith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@colesbury @pytorchbot @soumith @gchanan @ngimel