Skip to content

make valgrind_toggle and valgrind_supported_platform private #46718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
malfet merged 1 commit into from
Oct 23, 2020
Merged

make valgrind_toggle and valgrind_supported_platform private #46718

malfet merged 1 commit into from
Oct 23, 2020

Conversation

@albanD
Copy link
Collaborator

@albanD albanD commented Oct 22, 2020

Cherry pick of #46673

@robieta can you check that the merge conflicts have been properly handled?

@albanD albanD requested a review from robieta October 22, 2020 15:39
@albanD albanD mentioned this pull request Oct 22, 2020
Closed
@albanD albanD requested a review from gchanan October 22, 2020 15:43
robieta
robieta approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@robieta robieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 22, 2020 •
edited
Loading

Codecov Report

Merging #46718 into release/1.7 will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.7   #46718   +/-   ##
============================================
  Coverage        68.43%   68.43%           
============================================
  Files              406      406           
  Lines            52321    52321           
============================================
  Hits             35806    35806           
  Misses           16515    16515
Impacted Files Coverage Δ
torch/overrides.py 97.08% <ø> (ø)
...enchmark/utils/valgrind_wrapper/timer_interface.py 25.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6394982...f9127b3. Read the comment docs.

@dr-ci
Copy link

dr-ci bot commented Oct 22, 2020

💊 CI failures summary and remediations

As of commit f9127b3 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

codecov.io: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

@malfet malfet merged commit e85d494 into pytorch:release/1.7 Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@robieta robieta robieta approved these changes

@gchanan gchanan Awaiting requested review from gchanan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@albanD @malfet @robieta