Replace list(map(...)) constructs by list comprehensions #46461
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done by replacing the regexp `list\(map\(lambda (\w+): (.*?), (\w+)\)\)` by `[$2 for $1 in $3]`
Use the search regexp `list\(map\(lambda (\w+): (.*?), ([0-9a-z_.\]\[]+)\)\)`
Fixes an argument order confusion in distributed_test.py
Flamefire
requested review from
apaszke,
ezyang,
fmassa,
goldsborough,
mrshenli,
pritamdamania87,
rohan-varma,
soumith and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: jit
Contributor
💊 CI failures summary and remediationsAs of commit 9c06b80 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 5 times. |
This was referenced Oct 16, 2020
Flamefire
force-pushed
the
list_map_replacement
branch
from
030a249 to
9c06b80
Compare
Codecov Report
@@ Coverage Diff @@
## master #46461 +/- ##
=======================================
Coverage 68.38% 68.38%
=======================================
Files 411 411
Lines 53953 53953
=======================================
Hits 36897 36897
Misses 17056 17056
Continue to review full report at Codecov.
|
💊 CI failures summary and remediationsAs of commit 9c06b80 (more details on the Dr. CI page):
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. |
ezyang
approved these changes
Oct 16, 2020
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
2 similar comments
Contributor
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 22, 2020
Summary: Follow-up of #46461 with a similar goal Makes them more readable and possibly faster. Care has to be taken because `map` applies the function immediately while `(x for x in xs)` is a generator expression which gets evaluated later. This is a benefit in some cases where it is not required to actually create the list of values in memory (e.g. when passing to `tuple` or `extend` or `join`) Pull Request resolved: #46462 Reviewed By: zou3519 Differential Revision: D24422343 Pulled By: ezyang fbshipit-source-id: 252e33499c92ac0b15238f2df32681dbbda2b237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #46392 this makes the code more readable and possibly more performant.
It also fixes a bug detected by this where the argument order of
mapwas confused: Flamefire@030a249#diff-5bb26bd3a23ee3bb540aeadcc0385df2a4e48de39f87ed9ea76b21990738fe98L1537-R1537Fixes #46392