Skip to content

[v1.7 patch] Add warning on ProcessGroup and ProcessGroup::Work APIs #46366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
malfet merged 1 commit into from
Oct 15, 2020
Merged

[v1.7 patch] Add warning on ProcessGroup and ProcessGroup::Work APIs #46366

malfet merged 1 commit into from
Oct 15, 2020

Conversation

@agolynski
Copy link
Contributor

@agolynski agolynski commented Oct 15, 2020 •
edited
Loading

ghstack-source-id: f5427d315d18dc2585d68a394f36409602bbc505
Pull Request resolved: #46220

Differential revision: D24294437 (Jedi landed)

Commit: 604601b

This is NOOP change to track usages of ProcessGroup::Work API methods that are to be deprecated.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Oct 15, 2020
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 15, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 0fdbabc (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)---

Extra GitHub checks: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@agolynski agolynski requested a review from malfet October 15, 2020 00:02
@agolynski agolynski changed the title Add warning on ProcessGroup and ProcessGroup::Work APIs [v1.7 patch] Add warning on ProcessGroup and ProcessGroup::Work APIs Oct 15, 2020
@agolynski agolynski marked this pull request as ready for review October 15, 2020 00:06
@agolynski agolynski mentioned this pull request Oct 15, 2020
Closed
@dr-ci
Copy link

dr-ci bot commented Oct 15, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 0fdbabc (more details on the Dr. CI page):

  • 4/4 failures possibly* introduced in this PR
    • 3/4 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test2 (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

RuntimeError: test_jit_cuda_fuser failed! 
  test_broadcasting_partition_logic_1 (__main__.TestCudaFuser) ... ok (0.245s) 
  test_chunk (__main__.TestCudaFuser) ... ok (0.240s) 
  test_const (__main__.TestCudaFuser) ... ok (0.203s) 
  test_dynamic_size (__main__.TestCudaFuser) ... ok (0.227s) 
  test_half (__main__.TestCudaFuser) ... ok (0.234s) 
  test_pw_single_reduction_partition (__main__.TestCudaFuser) ... Traceback (most recent call last): 
  File "run_test.py", line 745, in <module> 
    main() 
  File "run_test.py", line 728, in main 
    raise RuntimeError(err_message) 
RuntimeError: test_jit_cuda_fuser failed! 
 
(base) circleci@PACKER-5F5FCBA1 C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1  
+ cleanup
+ retcode=1
+ set +x

Extra GitHub checks: 1 failed

ci.pytorch.org: 2 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

@malfet malfet merged commit 286647b into release/1.7 Oct 15, 2020
@facebook-github-bot facebook-github-bot deleted the agolynski/cp-46220 branch January 27, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@mrshenli mrshenli Awaiting requested review from mrshenli mrshenli is a code owner

@pietern pietern Awaiting requested review from pietern

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao zhaojuanmao is a code owner

Assignees

No one assigned

Labels

oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agolynski @facebook-github-bot @malfet