Skip to content

Conversation

@jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Oct 14, 2020

Stack from ghstack:

Summary:
Should we merge quantized module and quantized operator configurations?

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D24317435

Summary:
Should we merge quantized module and quantized operator configurations?

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 14, 2020

💊 CI failures summary and remediations

As of commit fa30163 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR---

1 failure not recognized by patterns:

Job Step Action
CircleCI docker-pytorch-linux-xenial-py3-clang5-android-ndk-r19c Check if image should be built 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

jerryzh168 added a commit that referenced this pull request Oct 14, 2020
Summary:
Should we merge quantized module and quantized operator configurations?

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 1094307
Pull Request resolved: #46338
@dr-ci
Copy link

dr-ci bot commented Oct 14, 2020

💊 CI failures summary and remediations

As of commit a702a6f (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 45 times.

…ent to convert"

Summary:
Should we merge quantized module and quantized operator configurations?

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317435](https://our.internmc.facebook.com/intern/diff/D24317435)

[ghstack-poisoned]
Comment on lines +259 to +266
"static": {
FloatModule: QuantizedModule,
float_op: quantized_op
},
"dynamic": {
FloatModule: DynamicallyQuantizedModule,
float_op: dynamically_quantized_op
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how would custom mappings for QAT, and/or for models which have some parts quantized dynamically and statically fit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean additional qat module mappings? it's added in the next PR. it's kind of independent from these, it happens before we insert observer, e.g. we swap nn.Conv2d to nn.qat.Conv2d

"static" and "dynamic" here are used during convert, e.g. nn.qat.Conv2d to nn.quantized.Conv2d

…ent to convert"

Summary:
Should we merge quantized module and quantized operator configurations?

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317435](https://our.internmc.facebook.com/intern/diff/D24317435)

[ghstack-poisoned]
…ent to convert"

Summary:
Should we merge quantized module and quantized operator configurations?

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317435](https://our.internmc.facebook.com/intern/diff/D24317435)

[ghstack-poisoned]
…ent to convert"

Summary:
Should we merge quantized module and quantized operator configurations?

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317435](https://our.internmc.facebook.com/intern/diff/D24317435)

[ghstack-poisoned]
…ent to convert"

Summary:
Should we merge quantized module and quantized operator configurations?

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317435](https://our.internmc.facebook.com/intern/diff/D24317435)

[ghstack-poisoned]
…ent to convert"

Summary:
Should we merge quantized module and quantized operator configurations?

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317435](https://our.internmc.facebook.com/intern/diff/D24317435)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 746febd.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/467/head branch October 25, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants