Skip to content

[quant] Remove prehook option #46292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jerryzh168 wants to merge 3 commits into from
Closed

[quant] Remove prehook option #46292

jerryzh168 wants to merge 3 commits into from

Conversation

@jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Oct 13, 2020 •
edited
Loading

Stack from ghstack:

Summary:
since it is not needed

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D24290815

@jerryzh168
[quant] Remove prehook option
739dffd 
Summary:
since it is not needed

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
This was referenced Oct 13, 2020
Closed
Closed
@jerryzh168
Update on "[quant] Remove prehook option"
9284ec3 
Summary:
since it is not needed

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24290815](https://our.internmc.facebook.com/intern/diff/D24290815)

[ghstack-poisoned]
raghuramank100
raghuramank100 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@raghuramank100 raghuramank100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a use case that used the prehook before?

@jerryzh168
Copy link
Contributor Author

jerryzh168 commented Oct 13, 2020

Was there a use case that used the prehook before?

it was added before for bias correction

@dr-ci
Copy link

dr-ci bot commented Oct 13, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 6393fd6 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 2 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 11 times.

@jerryzh168
Update on "[quant] Remove prehook option"
6393fd6 
Summary:
since it is not needed

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24290815](https://our.internmc.facebook.com/intern/diff/D24290815)

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Oct 14, 2020
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 14, 2020

This pull request has been merged in 53316e8.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/463/head branch October 18, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@raghuramank100 raghuramank100 raghuramank100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerryzh168 @facebook-github-bot @raghuramank100