Skip to content

annotate torch.autograd.* modules #46206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
malfet merged 1 commit into from
Oct 12, 2020
Merged

annotate torch.autograd.* modules #46206

malfet merged 1 commit into from
Oct 12, 2020

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Oct 12, 2020

@guilhermeleobas @malfet
annotate torch.autograd.* modules (pytorch#45004)
ecc599e 
Summary:
Fixes pytorch#44638

Pull Request resolved: pytorch#45004

Reviewed By: VitalyFedyunin

Differential Revision: D24113562

Pulled By: ezyang

fbshipit-source-id: a85018b7e08b2fe6cf2bc14a217eb418cb2b9de4
@malfet malfet requested review from albanD and apaszke as code owners October 12, 2020 18:59
@malfet malfet mentioned this pull request Oct 12, 2020
Closed
@dr-ci
Copy link

dr-ci bot commented Oct 12, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit ecc599e (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_backward_compatibility_check_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Oct 12 19:34:02 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
Oct 12 19:34:02 processing existing schema:  dilation(__torch__.torch.classes.quantized.Conv3dPackedParamsBase _0) -> (int[] _0) 
Oct 12 19:34:02 processing existing schema:  groups(__torch__.torch.classes.quantized.Conv3dPackedParamsBase _0) -> (int _0) 
Oct 12 19:34:02 processing existing schema:  __getstate__(__torch__.torch.classes.xnnpack.LinearOpContext _0) -> ((Tensor, Tensor?, Scalar?, Scalar?) _0) 
Oct 12 19:34:02 processing existing schema:  __setstate__(__torch__.torch.classes.xnnpack.LinearOpContext _0, (Tensor, Tensor?, Scalar?, Scalar?) _1) -> (None _0) 
Oct 12 19:34:02 processing existing schema:  __getstate__(__torch__.torch.classes.xnnpack.Conv2dOpContext _0) -> ((Tensor, Tensor?, int[], int[], int[], int, Scalar?, Scalar?) _0) 
Oct 12 19:34:02 processing existing schema:  __setstate__(__torch__.torch.classes.xnnpack.Conv2dOpContext _0, (Tensor, Tensor?, int[], int[], int[], int, Scalar?, Scalar?) _1) -> (None _0) 
Oct 12 19:34:02 schema:  preprocess(Any self, Any mod, Dict(str, Any) method_compile_spec) -> (Any mod)  found on allowlist, skipping 
Oct 12 19:34:02 schema:  compile(Any self, Any processed, Dict(str, Any) method_compile_spec) -> (Dict(str, Any) handles)  found on allowlist, skipping 
Oct 12 19:34:02 schema:  execute(Any self, Any handle, Any[] input) -> (Any[] output)  found on allowlist, skipping 
Oct 12 19:34:02 processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (None _0) 
Oct 12 19:34:02 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.  
Oct 12 19:34:02  
Oct 12 19:34:02 Broken ops: [ 
Oct 12 19:34:02 	aten::min_values(Tensor self, int[1] dim, bool keepdim=False) -> (Tensor) 
Oct 12 19:34:02 	aten::min_values.names(Tensor self, str[1] dim, bool keepdim=False) -> (Tensor) 
Oct 12 19:34:02 	aten::max_values(Tensor self, int[1] dim, bool keepdim=False) -> (Tensor) 
Oct 12 19:34:02 	aten::max_values.names(Tensor self, str[1] dim, bool keepdim=False) -> (Tensor) 
Oct 12 19:34:02 ] 
Oct 12 19:34:02 + cleanup 
Oct 12 19:34:02 + retcode=1 
Oct 12 19:34:02 + set +x

1 failure confirmed as flaky and can be ignored:

  • pytorch_linux_xenial_cuda9_2_cudnn7_py3_gcc5_4_build

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@malfet malfet merged commit 992d57b into pytorch:release/1.7 Oct 12, 2020
@malfet malfet deleted the malfet/pr-45004 branch October 12, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@albanD albanD albanD approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @seemethere @albanD @guilhermeleobas