Skip to content

Doc note update for complex autograd (CP-45270) #46072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
malfet merged 1 commit into from
Oct 9, 2020
Merged

Doc note update for complex autograd (CP-45270) #46072

malfet merged 1 commit into from
Oct 9, 2020

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Oct 9, 2020 •
edited
Loading

Cherry-pick of #45270 into release/1.7

Screen Shot 2020-10-07 at 1 45 59 PM

Screen Shot 2020-10-07 at 1 46 10 PM

Screen Shot 2020-10-07 at 1 46 30 PM

Screen Shot 2020-10-07 at 1 46 48 PM

Screen Shot 2020-10-07 at 1 47 03 PM

Screen Shot 2020-10-07 at 1 47 12 PM

@anjali411 @malfet
Doc note update for complex autograd (pytorch#45270)
b5ea2ad 
Summary:
Pull Request resolved: pytorch#45270

<img width="1679" alt="Screen Shot 2020-10-07 at 1 45 59 PM" src="https://user-images.githubusercontent.com/20081078/95368324-fa7b2d00-08a3-11eb-9066-2e659a4085a2.png">
<img width="1673" alt="Screen Shot 2020-10-07 at 1 46 10 PM" src="https://user-images.githubusercontent.com/20081078/95368332-fbac5a00-08a3-11eb-9be5-77ce6deb8967.png">
<img width="1667" alt="Screen Shot 2020-10-07 at 1 46 30 PM" src="https://user-images.githubusercontent.com/20081078/95368337-fe0eb400-08a3-11eb-80a2-5ad23feeeb83.png">
<img width="1679" alt="Screen Shot 2020-10-07 at 1 46 48 PM" src="https://user-images.githubusercontent.com/20081078/95368345-00710e00-08a4-11eb-96d9-e2d544554a4b.png">
<img width="1680" alt="Screen Shot 2020-10-07 at 1 47 03 PM" src="https://user-images.githubusercontent.com/20081078/95368350-023ad180-08a4-11eb-89b3-f079480741f4.png">
<img width="1680" alt="Screen Shot 2020-10-07 at 1 47 12 PM" src="https://user-images.githubusercontent.com/20081078/95368364-0535c200-08a4-11eb-82fc-9435a046e4ca.png">

Test Plan: Imported from OSS

Reviewed By: navahgar

Differential Revision: D24203257

Pulled By: anjali411

fbshipit-source-id: cd637dade5fb40cecf5d9f4bd03d508d36e26fcd
@malfet malfet changed the title Doc note update for complex autograd (#45270) Doc note update for complex autograd (CP-45270) Oct 9, 2020
@malfet malfet mentioned this pull request Oct 9, 2020
Closed
@dr-ci
Copy link

dr-ci bot commented Oct 9, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit b5ea2ad (more details on the Dr. CI page):

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@anjali411 anjali411 self-requested a review October 9, 2020 16:37
@malfet malfet merged commit e93ae1e into pytorch:release/1.7 Oct 9, 2020
@malfet malfet deleted the malfet/cp-45270 branch October 9, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anjali411 anjali411 anjali411 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@malfet @anjali411