Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Oct 6, 2020

Because access to https://sourceware.org/git/valgrind.git can be really slow especially in some regions

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet force-pushed the malfet/embed-callgrind-headers branch from fc4acd9 to c985a17 Compare October 6, 2020 20:02
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@robieta robieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #45914 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45914   +/-   ##
=======================================
  Coverage   68.20%   68.20%           
=======================================
  Files         410      410           
  Lines       53243    53243           
=======================================
  Hits        36313    36313           
  Misses      16930    16930           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0da6730...c985a17. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in 49af421.

@malfet malfet deleted the malfet/embed-callgrind-headers branch October 8, 2020 16:14
malfet added a commit to malfet/pytorch that referenced this pull request Oct 8, 2020
Summary:
Because access to https://sourceware.org/git/valgrind.git can be really slow especially in some regions

Pull Request resolved: pytorch#45914

Reviewed By: seemethere

Differential Revision: D24144420

Pulled By: malfet

fbshipit-source-id: a454c8c3182c570ec344bf6468bb5e55d8b8da79
seemethere pushed a commit that referenced this pull request Oct 8, 2020
Summary:
Because access to https://sourceware.org/git/valgrind.git can be really slow especially in some regions

Pull Request resolved: #45914

Reviewed By: seemethere

Differential Revision: D24144420

Pulled By: malfet

fbshipit-source-id: a454c8c3182c570ec344bf6468bb5e55d8b8da79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants