Skip to content

Make torch.lu support complex input on CUDA. #45898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nikitaved wants to merge 8 commits into from
Closed

Make torch.lu support complex input on CUDA. #45898

nikitaved wants to merge 8 commits into from

Conversation

@nikitaved
Copy link
Collaborator

@nikitaved nikitaved commented Oct 6, 2020 •
edited
Loading

As per title. LU decomposition is used for computing determinants, and I need this functionality to implement the matrix square root. Next PR on my list is to enable torch.det on CUDA with complex input.

@nikitaved nikitaved changed the title Make LU support complex input on CUDA. Make torch.lu support complex input on CUDA. Oct 6, 2020
@albanD albanD requested a review from anjali411 October 6, 2020 14:42
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 6, 2020
@anjali411 anjali411 added the module: complex Related to complex number support in PyTorch label Oct 6, 2020
@nikitaved nikitaved mentioned this pull request Oct 7, 2020
Closed
anjali411
anjali411 reviewed Oct 8, 2020
View reviewed changes
anjali411
anjali411 reviewed Oct 8, 2020
View reviewed changes
anjali411
anjali411 reviewed Oct 8, 2020
View reviewed changes
anjali411
anjali411 reviewed Oct 8, 2020
View reviewed changes
@dr-ci
Copy link

dr-ci bot commented Oct 12, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 195d9ee (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@codecov
Copy link

codecov bot commented Oct 12, 2020 •
edited
Loading

Codecov Report

Merging #45898 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45898   +/-   ##
=======================================
  Coverage   68.20%   68.20%           
=======================================
  Files         410      410           
  Lines       53453    53453           
=======================================
  Hits        36457    36457           
  Misses      16996    16996

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a814231...195d9ee. Read the comment docs.

@nikitaved nikitaved requested a review from anjali411 October 13, 2020 18:00
anjali411
anjali411 approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@anjali411 anjali411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @nikitaved

facebook-github-bot
facebook-github-bot reviewed Oct 14, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 16, 2020

@anjali411 merged this pull request in 9300a27.

@IvanYashchuk IvanYashchuk mentioned this pull request Oct 23, 2020
Closed
facebook-github-bot pushed a commit that referenced this pull request Nov 5, 2020
@nikitaved @facebook-github-bot
Make torch.det() support complex input. (#45980)
8a3728c 
Summary:
As per title. A minor fix required to make it available for the CPU (`fmod` does not support complex).
For CUDA requires [#45898 ](#45898).

Pull Request resolved: #45980

Reviewed By: izdeby

Differential Revision: D24539097

Pulled By: anjali411

fbshipit-source-id: 508830dbfd7794ab73e19320d07c69a051c91819
@facebook-github-bot facebook-github-bot deleted the nikved/complex_lu branch January 27, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@anjali411 anjali411 anjali411 approved these changes

Assignees

No one assigned

Labels

Merged module: complex Related to complex number support in PyTorch open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nikitaved @facebook-github-bot @anjali411 @albanD @pytorchbot