Skip to content

Disable angle backwards #45839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
malfet merged 1 commit into from
Oct 6, 2020
Merged

Disable angle backwards #45839

malfet merged 1 commit into from
Oct 6, 2020

Conversation

@anjali411
Copy link
Contributor

@anjali411 anjali411 commented Oct 5, 2020

No description provided.

@anjali411 anjali411 requested review from albanD and gchanan October 5, 2020 14:42
@anjali411 anjali411 added this to the 1.7.0 milestone Oct 5, 2020
@anjali411 anjali411 added the module: complex Related to complex number support in PyTorch label Oct 5, 2020
albanD
albanD reviewed Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove angle here?

Also should add be added to the allowlist for testing to work?

@anjali411
Copy link
Contributor Author

anjali411 commented Oct 5, 2020

Why did you remove angle here?

Also should add be added to the allowlist for testing to work?

torch.angle returned complex gradients for real tensors, and was also not double differentiable before this PR #44444. @gchanan suggested to not merge #44444 any feature addition after branch cut, so it seems like disabling torch.angle might be good since we are disabling backward for majority of functions for complex in this release.

add already exists in the allowlist. Currently, since we don't have R to C backward tests, the lack in R to C handling for add went unnoticed.

@anjali411 anjali411 requested a review from albanD October 5, 2020 15:10
albanD
albanD approved these changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho. I didn't see that was again the release branch.
LGTM.

@anjali411 anjali411 mentioned this pull request Oct 5, 2020
Closed
@anjali411 anjali411 changed the title Disable angle backwards and handle r to c backward for add Disable angle backwards Oct 5, 2020
@malfet malfet merged commit 65a1827 into release/1.7 Oct 6, 2020
@facebook-github-bot facebook-github-bot deleted the release_changes branch January 27, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@gchanan gchanan Awaiting requested review from gchanan

Assignees

No one assigned

Labels

module: complex Related to complex number support in PyTorch

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@anjali411 @albanD @malfet