Skip to content

[ONNX] export sum, prod, sqrt improve log_softmax. #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soumith merged 7 commits into from
Jan 12, 2018
Merged

[ONNX] export sum, prod, sqrt improve log_softmax. #4579

soumith merged 7 commits into from
Jan 12, 2018

Conversation

@sighingnow
Copy link
Contributor

@sighingnow sighingnow commented Jan 10, 2018

More exports:

  • sum
  • prod
  • sqrt

Improve:

  • log_softmax

Doc:

  • Fix a URL typo in docs/source/onnx.rst

@sighingnow
ONNX: export sum, prod, sqrt improve log_softmax and fix a typo in doc.
a9e9fe5 
Signed-off-by: HE, Tao <sighingnow@gmail.com>
@sighingnow
Add new exported op to doc.
29859a6 
Signed-off-by: HE, Tao <sighingnow@gmail.com>
@houseroad
Copy link
Member

houseroad commented Jan 10, 2018

Could you also add the onnx tests in https://github.com/onnxbot/onnx-fb-universe/blob/master/test/test_operators.py?

@ezyang
Copy link
Contributor

ezyang commented Jan 10, 2018

@pytorchbot test this please

This is so legit! Thank you!

@ezyang
Copy link
Contributor

ezyang commented Jan 10, 2018

The test output needs updating. It's as simple as running python test/test_jit.py --accept.

ngimel
ngimel reviewed Jan 11, 2018
View reviewed changes
torch/onnx/symbolic.py Outdated


def sqrt(g, self):
return g.op('Sqrt', self)

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@sighingnow
Double quotes.
d4a986d 
Signed-off-by: HE, Tao <sighingnow@gmail.com>
@sighingnow
Update trace log of log_softmax.
5964d5b 
Signed-off-by: HE, Tao <sighingnow@gmail.com>
@sighingnow
Copy link
Contributor Author

sighingnow commented Jan 11, 2018

Update trace log for log_softmax.

@sighingnow
Improve export when dim is None and axes_i should be a list of ints.
de165e9 
Signed-off-by: HE, Tao <sighingnow@gmail.com>
@sighingnow
Copy link
Contributor Author

sighingnow commented Jan 11, 2018

Update axis_i to "list of ints", according to the onnx's doc: https://github.com/onnx/onnx/blob/master/docs/Operators.md#attributes-48

@sighingnow
Fix prod when no dim given.
e208712 
Signed-off-by: HE, Tao <sighingnow@gmail.com>
@sighingnow sighingnow mentioned this pull request Jan 11, 2018
Merged
@sighingnow
Copy link
Contributor Author

sighingnow commented Jan 11, 2018

Onnx test done in onnxbot/onnx-fb-universe#247

/cc: @houseroad

@sighingnow
Copy link
Contributor Author

sighingnow commented Jan 11, 2018

@pytorchbot retest this please

1 similar comment
@soumith
Copy link
Contributor

soumith commented Jan 11, 2018

@pytorchbot retest this please

@sighingnow
Update line ends in test expected file.
2766c2a 
Signed-off-by: HE, Tao <sighingnow@gmail.com>
@sighingnow
Copy link
Contributor Author

sighingnow commented Jan 12, 2018

Line ends fixed.

@soumith soumith merged commit b42f163 into pytorch:master Jan 12, 2018
@soumith
Copy link
Contributor

soumith commented Jan 12, 2018

thank you @sighingnow !

ezyang pushed a commit to ezyang/pytorch that referenced this pull request Feb 10, 2018
@sighingnow @ezyang
[ONNX] export sum, prod, sqrt improve log_softmax. (pytorch#4579)
bc75b1c 
* ONNX: export sum, prod, sqrt improve log_softmax and fix a typo in doc.

Signed-off-by: HE, Tao <sighingnow@gmail.com>

* Add new exported op to doc.

Signed-off-by: HE, Tao <sighingnow@gmail.com>

* Double quotes.

Signed-off-by: HE, Tao <sighingnow@gmail.com>

* Update trace log of log_softmax.

Signed-off-by: HE, Tao <sighingnow@gmail.com>

* Improve export when dim is None and axes_i should be a list of ints.

Signed-off-by: HE, Tao <sighingnow@gmail.com>

* Fix prod when no dim given.

Signed-off-by: HE, Tao <sighingnow@gmail.com>

* Update line ends in test expected file.

Signed-off-by: HE, Tao <sighingnow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel left review comments

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sighingnow @houseroad @ezyang @soumith @ngimel