Skip to content

SET USE_DISTRIBUTED OFF when libuv is not installed #45554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gunandrose4u wants to merge 16 commits into from
Closed

SET USE_DISTRIBUTED OFF when libuv is not installed #45554

gunandrose4u wants to merge 16 commits into from

Conversation

@gunandrose4u
Copy link
Contributor

@gunandrose4u gunandrose4u commented Sep 30, 2020

Fixes #{issue number}

gunandrose4u and others added 15 commits August 17, 2020 11:27
@gunandrose4u
Merge pull request #1 from pytorch/master
bf02d77 
Update my fork from Pytorch repo
@gunandrose4u
Merge pull request #2 from pytorch/master
2ebe620 
Rebase from pytorch/pytorch master
@gunandrose4u
Merge pull request #3 from pytorch/master
04f7b51 
Rebase latest code from master branch of PyTorch repo
@gunandrose4u
Merge pull request #4 from pytorch/master
afbc6c1 
Rebase code
@gunandrose4u
Merge pull request #5 from pytorch/master
c933f32 
Rebase to latest commits
@gunandrose4u
Merge pull request #6 from pytorch/master
ddd80bc 
Rebase to latest commits
@gunandrose4u
Merge pull request #7 from pytorch/master
cd3d2af 
Rebase to latest commit
@gunandrose4u
Merge pull request #8 from pytorch/master
450742a 
Rebase to latest commits
@gunandrose4u
Merge pull request #9 from pytorch/master
34ed95a 
Rebase to latest commits
@gunandrose4u
Merge pull request #10 from pytorch/master
a6d5771 
Rebase to latest commits
@gunandrose4u
Merge pull request #13 from pytorch/master
96927c0 
Rebase latest commits
@gunandrose4u
Merge pull request #14 from pytorch/master
9147d60 
Rebase latest commits
@gunandrose4u
Merge pull request #15 from pytorch/master
c14c4c5 
Rebase to latest commits
@gunandrose4u
Merge pull request #16 from pytorch/master
fd8817f 
Rebase latest commits
@gunandrose4u
set USE_DISTRIBUTED to OFF when libuv is not installed in build conda…
769b059 
… env and libuv_ROOT does not set.
@nbcsm nbcsm requested review from malfet and mrshenli September 30, 2020 03:26
@dr-ci
Copy link

dr-ci bot commented Sep 30, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit f6723a7 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 2 failures tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_macos_10_13_py3_test (1/2)

Step: "Update Homebrew" (full log | diagnosis details | 🔁 rerun) ❄️

fatal: Could not read from remote repository. 
Receiving objects:  98% (175/178) Receiving objects:  99% (177/178) Receiving objects: 100% (178/178) Receiving objects: 100% (178/178), 63.90 KiB | 10.65 MiB/s, done. 
Resolving deltas:  96% (89/92) Resolving deltas:  97% (90/92) Resolving deltas: 100% (92/92) Resolving deltas: 100% (92/92), completed with 85 local objects. 
From ssh://github.com/Homebrew/homebrew-cask-versions 
 + 15f6b44...90ed6b8 master     -> origin/master  (forced update) 
+ git reset --hard origin/master 
HEAD is now at 90ed6b8 Update microsoft-edge-beta from 86.0.622.19 to 86.0.622.28 (#9686) 
+ for path in '$(find /usr/local/Homebrew -type d -name .git)' 
+ cd /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/.git/.. 
+ git fetch --depth=1 origin 
Connection to github.com closed by remote host.  
fatal: Could not read from remote repository. 
 
Please make sure you have the correct access rights 
and the repository exists.

See CircleCI build binary_macos_libtorch_3_7_cpu_build (2/2)

Step: "Update Homebrew" (full log | diagnosis details | 🔁 rerun) ❄️

fatal: Could not read from remote repository. 
Receiving objects:  98% (175/178) Receiving objects:  99% (177/178) Receiving objects: 100% (178/178) Receiving objects: 100% (178/178), 63.88 KiB | 10.65 MiB/s, done. 
Resolving deltas:  96% (89/92) Resolving deltas:  97% (90/92) Resolving deltas: 100% (92/92) Resolving deltas: 100% (92/92), completed with 85 local objects. 
From ssh://github.com/Homebrew/homebrew-cask-versions 
 + 15f6b44...b470f4c master     -> origin/master  (forced update) 
+ git reset --hard origin/master 
HEAD is now at b470f4c Update rstudio-preview from 1.3.1091 to 1.4.869 (#9688) 
+ for path in '$(find /usr/local/Homebrew -type d -name .git)' 
+ cd /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/.git/.. 
+ git fetch --depth=1 origin 
Connection to github.com closed by remote host.  
fatal: Could not read from remote repository. 
 
Please make sure you have the correct access rights 
and the repository exists.

1 failure confirmed as flaky and can be ignored:

  • pytorch_ios_11_2_1_x86_64_build
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 8 times.

mrshenli
mrshenli approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

facebook-github-bot
facebook-github-bot reviewed Sep 30, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 1, 2020

@mrshenli merged this pull request in ffd50b8.

mrshenli pushed a commit to mrshenli/pytorch that referenced this pull request Oct 2, 2020
@gunandrose4u @mrshenli
SET USE_DISTRIBUTED OFF when libuv is not installed (pytorch#45554)
626f4af 
Pull Request resolved: pytorch#45554

Reviewed By: izdeby

Differential Revision: D24016825

Pulled By: mrshenli

fbshipit-source-id: 332d860429626a915c06f98cad31e6db1cbc4eb1
This was referenced Oct 2, 2020
Merged
Closed
malfet pushed a commit that referenced this pull request Oct 6, 2020
@mrshenli @gunandrose4u
SET USE_DISTRIBUTED OFF when libuv is not installed (#45554) (#45739)
30d41fa 
Pull Request resolved: #45554

Reviewed By: izdeby

Differential Revision: D24016825

Pulled By: mrshenli

fbshipit-source-id: 332d860429626a915c06f98cad31e6db1cbc4eb1

Co-authored-by: gunandrose4u <52735340+gunandrose4u@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mrshenli mrshenli mrshenli approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gunandrose4u @facebook-github-bot @mrshenli @pytorchbot @mruberry