Upgrade ReadMe document to guide user to install libuv(1.39) in conda env on Windows platform #45553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update my fork from Pytorch repo
Rebase from pytorch/pytorch master
Rebase latest code from master branch of PyTorch repo
Rebase code
Rebase to latest commits
Rebase to latest commits
Rebase to latest commit
Rebase to latest commits
Rebase to latest commits
Rebase to latest commits
Rebase latest commits
Rebase latest commits
Rebase to latest commits
Rebase latest commits
💊 CI failures summary and remediationsAs of commit dba034a (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
mrshenli
reviewed
Sep 30, 2020
| # Add these packages if torch.distributed is needed. | ||
| # Distributed package support on Windows is a prototype feature and is subject to changes. | ||
| conda install -y -q -c rdonnelly libuv | ||
| conda install -c conda-forge libuv=1.39 |
Contributor
There was a problem hiding this comment.
looking at anaconda cloud, conda-forge channel does not have libuv 1.39 for windows, but anaconda channel does. Or did I miss anything?
https://anaconda.org/conda-forge/libuv/files
https://anaconda.org/anaconda/libuv/files
Contributor
There was a problem hiding this comment.
Check with @gunandrose4u offline. Looks like conda-forge would also query anaconda channel.
mrshenli
approved these changes
Sep 30, 2020
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
mrshenli
pushed a commit
to mrshenli/pytorch
that referenced
this pull request
Oct 2, 2020
Summary: Pin the libuv versoin to v1.39 for Windows platform. Pull Request resolved: pytorch#45553 Reviewed By: SciPioneer Differential Revision: D24017246 Pulled By: mrshenli fbshipit-source-id: ec69f864a7acfbdddd60c3d2b442294ec3e34558
This was referenced Oct 2, 2020
malfet
pushed a commit
that referenced
this pull request
Oct 6, 2020
Summary: Pin the libuv versoin to v1.39 for Windows platform. Pull Request resolved: #45553 Reviewed By: SciPioneer Differential Revision: D24017246 Pulled By: mrshenli fbshipit-source-id: ec69f864a7acfbdddd60c3d2b442294ec3e34558 Co-authored-by: gunandrose4u <52735340+gunandrose4u@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #{issue number}