Skip to content

Enable PE + TE #45546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Krovatkin wants to merge 2 commits into from
Closed

Enable PE + TE #45546

Krovatkin wants to merge 2 commits into from

Conversation

@Krovatkin
Copy link
Contributor

@Krovatkin Krovatkin commented Sep 30, 2020

This PR enables PE + TE for 1.7

@Krovatkin Krovatkin requested a review from apaszke as a code owner September 30, 2020 00:26
ZolotukhinM
ZolotukhinM approved these changes Sep 30, 2020
View reviewed changes
Copy link

@ZolotukhinM ZolotukhinM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Sep 30, 2020
facebook-github-bot
facebook-github-bot reviewed Sep 30, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link

dr-ci bot commented Sep 30, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit fc682cd (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_ge_config_simple_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Sep 30 07:58:17 [E request_callback_no_python.cpp:581] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 30 07:58:17 At: 
Sep 30 07:58:17   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 30 07:58:17   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 30 07:58:17  
Sep 30 07:58:17 [E request_callback_no_python.cpp:581] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 30 07:58:17  
Sep 30 07:58:17 At: 
Sep 30 07:58:17   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 30 07:58:17   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 30 07:58:17  
Sep 30 07:58:17 [E request_callback_no_python.cpp:581] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 30 07:58:17  
Sep 30 07:58:17 At: 
Sep 30 07:58:17   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 30 07:58:17   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 30 07:58:17  
Sep 30 07:58:17 [W tensorpipe_agent.cpp:545] RPC agent for worker2 encountered error when reading incoming request from worker1: EOF: end of file (this is expected to happen during shutdown) 
Sep 30 07:58:17 [W tensorpipe_agent.cpp:545] RPC agent for worker2 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Sep 30 07:58:17 ok (1.740s) 
Sep 30 07:58:19   test_return_future_remote (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:545] RPC agent for worker2 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Sep 30 07:58:19 [W tensorpipe_agent.cpp:545] RPC agent for worker3 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

@codecov
Copy link

codecov bot commented Sep 30, 2020 •
edited
Loading

Codecov Report

Merging #45546 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #45546      +/-   ##
==========================================
+ Coverage   68.56%   68.60%   +0.03%     
==========================================
  Files         405      405              
  Lines       51969    51969              
==========================================
+ Hits        35635    35654      +19     
+ Misses      16334    16315      -19
Impacted Files Coverage Δ
torch/testing/_internal/common_utils.py 78.20% <0.00%> (+0.99%) ⬆️
torch/testing/_internal/jit_utils.py 89.69% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22a34bc...fc682cd. Read the comment docs.

facebook-github-bot
facebook-github-bot reviewed Sep 30, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 30, 2020

@Krovatkin merged this pull request in 7566823.

Krovatkin added a commit to Krovatkin/pytorch that referenced this pull request Sep 30, 2020
@Krovatkin
Enable PE + TE (pytorch#45546)
ff17372 
Summary:
This PR enables PE + TE for 1.7

Pull Request resolved: pytorch#45546

Reviewed By: ZolotukhinM

Differential Revision: D24006940

Pulled By: Krovatkin

fbshipit-source-id: a3326077d34a023941acdb06c4907c96e7ba0115
@Krovatkin Krovatkin mentioned this pull request Sep 30, 2020
Closed
malfet pushed a commit that referenced this pull request Sep 30, 2020
@Krovatkin
Enable PE + TE (#45546) (#45591)
07e66d7 
Summary:
This PR enables PE + TE for 1.7

Pull Request resolved: #45546

Reviewed By: ZolotukhinM

Differential Revision: D24006940

Pulled By: Krovatkin

fbshipit-source-id: a3326077d34a023941acdb06c4907c96e7ba0115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@apaszke apaszke Awaiting requested review from apaszke

@eellison eellison Awaiting requested review from eellison

+2 more reviewers

@bertmaher bertmaher bertmaher approved these changes

@ZolotukhinM ZolotukhinM ZolotukhinM approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Krovatkin @facebook-github-bot @bertmaher @ZolotukhinM @mruberry