Skip to content

Fix model_name not logged properly issue. #45488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xcheng16 wants to merge 1 commit into from
Closed

Fix model_name not logged properly issue. #45488

xcheng16 wants to merge 1 commit into from

Conversation

@xcheng16
Copy link
Contributor

@xcheng16 xcheng16 commented Sep 29, 2020 •
edited
Loading

Stack from ghstack:

model_name logging was broken, issue is from the recent change of assigning the method name into the module name, this diff is fixing it.

Differential Revision: D23984165

@xcheng16
Fix model_name not logged properly issue.
e2673bb 
model_name logging was broken, issue is from the recent change of assigning the method name into the module name, this diff is fixing it.

Differential Revision: [D23984165](https://our.internmc.facebook.com/intern/diff/D23984165/)

[ghstack-poisoned]
@xcheng16 xcheng16 requested a review from apaszke as a code owner September 29, 2020 05:35
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Sep 29, 2020
xcheng16 added a commit that referenced this pull request Sep 29, 2020
@xcheng16
Fix model_name not logged properly issue.
eabd1b0 
model_name logging was broken, issue is from the recent change of assigning the method name into the module name, this diff is fixing it.

Differential Revision: [D23984165](https://our.internmc.facebook.com/intern/diff/D23984165/)

ghstack-source-id: 113103942
Pull Request resolved: #45488
@dr-ci
Copy link

dr-ci bot commented Sep 29, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit e2673bb (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_ge_config_simple_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Sep 29 07:48:27 [E request_callback_no_python.cpp:581] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 29 07:48:27 At: 
Sep 29 07:48:27   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 29 07:48:27   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 29 07:48:27  
Sep 29 07:48:27 [E request_callback_no_python.cpp:581] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 29 07:48:27  
Sep 29 07:48:27 At: 
Sep 29 07:48:27   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 29 07:48:27   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 29 07:48:27  
Sep 29 07:48:27 [E request_callback_no_python.cpp:581] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 29 07:48:27  
Sep 29 07:48:27 At: 
Sep 29 07:48:27   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 29 07:48:27   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 29 07:48:27  
Sep 29 07:48:28 ok (1.739s) 
Sep 29 07:48:29   test_return_future_remote (__main__.ProcessGroupRpcTestWithSpawn) ... RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Sep 29 07:48:29 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Sep 29 07:48:29 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Sep 29 07:48:29 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 29, 2020

This pull request has been merged in ea59251.

@facebook-github-bot facebook-github-bot deleted the gh/xcheng16/33/head branch October 3, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xcheng16 @facebook-github-bot @mruberry