Skip to content

Add mobile_optimized tag to optimized model. #45479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
axitkhurana wants to merge 1 commit into from
Closed

Add mobile_optimized tag to optimized model. #45479

axitkhurana wants to merge 1 commit into from

Conversation

@axitkhurana
Copy link

@axitkhurana axitkhurana commented Sep 29, 2020

Summary: Add a top level boolean attribute to the model called mobile_optimized that is set to true if it is optimized.

Test Plan: buck test //caffe2/test:mobile passes

Differential Revision: D23956728

@facebook-github-bot
Add mobile_optimized tag to optimized model.
fdd9051 
Summary: Add a top level boolean attribute to the model called mobile_optimized that is set to true if it is optimized.

Test Plan: buck test //caffe2/test:mobile passes

Differential Revision: D23956728

fbshipit-source-id: 194d73a12d170c620d12b1846a160308e81bd1aa
@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue fb-exported labels Sep 29, 2020
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 29, 2020

This pull request was exported from Phabricator. Differential Revision: D23956728

@dr-ci
Copy link

dr-ci bot commented Sep 29, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit fdd9051 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_ios_11_2_1_x86_64_build (1/1)

Step: "Update Homebrew" (full log | diagnosis details | 🔁 rerun) ❄️

fatal: Could not read from remote repository. 
Receiving objects:  98% (175/178) Receiving objects:  99% (177/178) Receiving objects: 100% (178/178) Receiving objects: 100% (178/178), 63.88 KiB | 10.65 MiB/s, done. 
Resolving deltas:  96% (89/92) Resolving deltas:  97% (90/92) Resolving deltas: 100% (92/92) Resolving deltas: 100% (92/92), completed with 85 local objects. 
From ssh://github.com/Homebrew/homebrew-cask-versions 
 + 15f6b44...92646be master     -> origin/master  (forced update) 
+ git reset --hard origin/master 
HEAD is now at 92646be Update dropbox-beta from 107.3.412 to 107.3.416 (#9683) 
+ for path in '$(find /usr/local/Homebrew -type d -name .git)' 
+ cd /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/.git/.. 
+ git fetch --depth=1 origin 
Connection to github.com closed by remote host.  
fatal: Could not read from remote repository. 
 
Please make sure you have the correct access rights 
and the repository exists.
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 29, 2020

This pull request has been merged in 5f49d14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

fb-exported Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@axitkhurana @facebook-github-bot @mruberry