Skip to content

Conversation

@ranman
Copy link

@ranman ranman commented Sep 28, 2020

Fixes #4320

@ranman ranman requested a review from zou3519 September 28, 2020 22:26
@dr-ci
Copy link

dr-ci bot commented Sep 28, 2020

💊 CI failures summary and remediations

As of commit 60a767d (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

Extra GitHub checks: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #45468 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45468   +/-   ##
=======================================
  Coverage   68.05%   68.05%           
=======================================
  Files         396      396           
  Lines       51235    51235           
=======================================
  Hits        34868    34868           
  Misses      16367    16367           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c3fbc...60a767d. Read the comment docs.

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for sending a PR!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@albanD merged this pull request in ab5cf16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

torch.std NaN gradient

4 participants