Skip to content

Type check quasirandom #45434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
walterddr wants to merge 3 commits into from
Closed

Type check quasirandom #45434

walterddr wants to merge 3 commits into from

Conversation

@walterddr
Copy link
Contributor

@walterddr walterddr commented Sep 28, 2020

Fixes #42978.

@ajitmaths
Update mypy.ini
3c9ef44 
Enable torch.quasirandom typechecks
@ajitmaths
Update quasirandom.py
7575448 
Enable torch.quasirandom typechecks

Fixes pytorch#42978
@walterddr
Copy link
Contributor Author

walterddr commented Sep 28, 2020

@ajitmaths please import this PR using the "Import to Phabricator" button so that you can have the change reviewed and merged

@walterddr walterddr mentioned this pull request Sep 28, 2020
Closed
@dr-ci
Copy link

dr-ci bot commented Sep 28, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 80266a3 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun) <confirmed not flaky by 2 failures>

Sep 28 20:39:30 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 28 20:39:30 At: 
Sep 28 20:39:30   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 28 20:39:30   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 28 20:39:30  
Sep 28 20:39:30 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 28 20:39:30  
Sep 28 20:39:30 At: 
Sep 28 20:39:30   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 28 20:39:30   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 28 20:39:30  
Sep 28 20:39:30 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 28 20:39:30  
Sep 28 20:39:30 At: 
Sep 28 20:39:30   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 28 20:39:30   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 28 20:39:30  
Sep 28 20:39:30 ok (1.623s) 
Sep 28 20:39:32   test_return_future_remote (__main__.ProcessGroupRpcTestWithSpawn) ... RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Sep 28 20:39:32 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Sep 28 20:39:32 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Sep 28 20:39:32 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 6 times.

facebook-github-bot
facebook-github-bot reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajitmaths has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajitmaths has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 29, 2020

@ajitmaths merged this pull request in 5855aa8.

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 29, 2020

@ajitmaths merged this pull request in 5855aa8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable torch.quasirandom typechecks during CI

4 participants

@walterddr @facebook-github-bot @mruberry @ajitmaths