Ensure convolution weights are contiguous, fixes #4500 #4543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Contributor
|
@ezyang isn't it cleaner to just have the CuDNN bindings make weight contiguous always...? |
yf225
reviewed
Jan 9, 2018
aten/src/ATen/native/Convolution.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
Yeah, I was vacillating between the two ways. I'll swap it.
It's not just a CI error; it's a legit bug. Thanks for pointing it out! |
apaszke
approved these changes
Jan 9, 2018
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
ezyang
force-pushed
the
pr/convolution-weight-contiguous
branch
from
ac8c90a to
3224c35
Compare
Contributor
|
@pytorchbot retest this please |
2 similar comments
Contributor
|
@pytorchbot retest this please |
Contributor
Author
|
@pytorchbot retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Edward Z. Yang ezyang@fb.com