Skip to content

Updates torch.floor_divide documentation to clarify it's actually torch.trunc_divide (or torch.rtz_divide) #45411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mruberry wants to merge 2 commits into from
Closed

Updates torch.floor_divide documentation to clarify it's actually torch.trunc_divide (or torch.rtz_divide) #45411

mruberry wants to merge 2 commits into from

Conversation

@mruberry
Copy link
Collaborator

@mruberry mruberry commented Sep 28, 2020

Addresses #43874 for 1.7. 1.8 will need to take floor_divide through a proper deprecation process.

@mruberry mruberry added this to the 1.7.0 milestone Sep 28, 2020
@mruberry mruberry requested a review from gchanan September 28, 2020 03:30
@codecov
Copy link

codecov bot commented Sep 28, 2020 •
edited
Loading

Codecov Report

Merging #45411 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45411   +/-   ##
=======================================
  Coverage   68.15%   68.15%           
=======================================
  Files         396      396           
  Lines       51137    51137           
=======================================
+ Hits        34850    34851    +1     
+ Misses      16287    16286    -1
Impacted Files Coverage Δ
torch/_torch_docs.py 100.00% <100.00%> (ø)
torch/testing/_internal/expecttest.py 78.57% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b839bc...5aab255. Read the comment docs.

facebook-github-bot
facebook-github-bot reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

gchanan
gchanan reviewed Sep 28, 2020
View reviewed changes
facebook-github-bot
facebook-github-bot reviewed Sep 29, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link

dr-ci bot commented Sep 29, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 5aab255 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 29, 2020

@mruberry merged this pull request in 87f98a5.

@facebook-github-bot facebook-github-bot deleted the floor_div_docs_fix branch January 27, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@gchanan gchanan gchanan approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mruberry @facebook-github-bot @gchanan