[Distributed] DeleteKey API for c10d TCP Store #45401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a DeleteKey API for the TCP Store Differential Revision: [D23955730](https://our.internmc.facebook.com/intern/diff/D23955730/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D23955730/)! [ghstack-poisoned]
osalpekar
requested review from
mrshenli,
pietern,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit e977bc4 (more details on the Dr. CI page):
1 job timed out:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
mrshenli
approved these changes
Sep 28, 2020
|
|
||
| virtual int64_t getNumKeys() override; | ||
|
|
||
| virtual bool deleteKey(const std::string& key) override; |
Contributor
There was a problem hiding this comment.
Is this part of API still used by any active code path?
Member
Author
There was a problem hiding this comment.
It seems like it is used in some examples/tests in the Caffe2 codebase as well as in one CV application internally, but it's not used in PyTorch code.
Contributor
|
This pull request has been merged in 6b65b3c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Reland of #43963
Added a DeleteKey API for the TCP Store
Differential Revision: D23955730
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!