Skip to content

Fix torch.diag backward with non-square matrix #4538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soumith merged 2 commits into from
Feb 5, 2018
Merged

Fix torch.diag backward with non-square matrix #4538

soumith merged 2 commits into from
Feb 5, 2018

Conversation

@zou3519
Copy link
Contributor

@zou3519 zou3519 commented Jan 8, 2018

Fixes #4299

Previously, the gradient of a non-square matrix input to torch.diag would be a square matrix. This fixes that.

Test Plan

New unit test in test_autograd. Also run the following and verify the size of x.grad is okay:

x = Variable(torch.randn(3, 5), requires_grad=True)
x.diag().sum().backward()
x.grad.size()  # assert this is (3, 5)

@onnxbot-worker-1 onnxbot-worker-1 mentioned this pull request Jan 8, 2018
Closed
apaszke
apaszke reviewed Jan 9, 2018
View reviewed changes
tools/autograd/templates/Functions.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

tools/autograd/templates/Functions.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

apaszke
apaszke reviewed Jan 10, 2018
View reviewed changes
tools/autograd/templates/Functions.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@onnxbot-worker-3 onnxbot-worker-3 mentioned this pull request Jan 22, 2018
Closed
ssnl
ssnl reviewed Feb 1, 2018
View reviewed changes
tools/autograd/templates/Functions.cpp Outdated

This comment was marked as off-topic.

Sign in to view

tools/autograd/templates/Functions.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ssnl
ssnl approved these changes Feb 5, 2018
View reviewed changes
Copy link
Collaborator

@ssnl ssnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumith soumith merged commit e4eaf67 into pytorch:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gchanan gchanan gchanan left review comments

@ssnl ssnl ssnl approved these changes

+1 more reviewer

@apaszke apaszke apaszke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

log_softmax + torch.diag backward() error

5 participants

@zou3519 @gchanan @apaszke @ssnl @soumith